π deploy(release): sync dev/v1.6 β main for v1.6.0-rc.10 - #648
Merged
Conversation
scttbnsn
requested review from
ALARGECOMPANY and
biggest-littlest
as code owners
July 31, 2026 20:39
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
π WalkthroughWalkthroughThe release candidate advances to Possibly related PRs
π₯ Pre-merge checks | β 1 | β 1β Failed checks (1 warning)
β Passed checks (1 passed)
β¨ Finishing Touchesπ Generate docstrings
π§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
scttbnsn
dismissed stale reviews from ALARGECOMPANY and biggest-littlest
July 31, 2026 20:44
The merge-base changed after approval.
scttbnsn
force-pushed
the
release/v1.6-rc10-main-sync
branch
from
July 31, 2026 20:44
fb76122 to
56724a9
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 14
π§Ή Nitpick comments (1)
ui/src/locales/fr/containerComponents.json (1)
464-464: π Maintainability & Code Quality | π΅ Trivial | β‘ Quick winKeep Crowdin-managed locale catalogs free of manually added keys.
softBlockerLearnMoreshould remain inui/src/locales/en/containerComponents.json. Remove the added entry from each non-English catalog. Do not commit duplicate English values while waiting for Crowdin translations.
ui/src/locales/fr/containerComponents.json#L464-L464: remove the manually seeded English entry.ui/src/locales/ar/containerComponents.json#L464-L464: remove the manually seeded English entry.ui/src/locales/de/containerComponents.json#L464-L464: remove the manually seeded English entry.ui/src/locales/es/containerComponents.json#L464-L464: remove the manually seeded English entry.ui/src/locales/it/containerComponents.json#L464-L464: remove the manually seeded English entry.ui/src/locales/pt-BR/containerComponents.json#L464-L464: remove the manually seeded English entry.ui/src/locales/pl/containerComponents.json#L464-L464: remove the manually seeded English entry.ui/src/locales/ru/containerComponents.json#L464-L464: remove the manually seeded English entry.Based on learnings,
ui/src/locales/en/is authoritative and non-English catalogs are Crowdin-managed; do not hand-seed new translation keys.π€ Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ui/src/locales/fr/containerComponents.json` at line 464, Remove the manually added softBlockerLearnMore entry from ui/src/locales/fr/containerComponents.json#L464-L464, ui/src/locales/ar/containerComponents.json#L464-L464, ui/src/locales/de/containerComponents.json#L464-L464, ui/src/locales/es/containerComponents.json#L464-L464, ui/src/locales/it/containerComponents.json#L464-L464, ui/src/locales/pt-BR/containerComponents.json#L464-L464, ui/src/locales/pl/containerComponents.json#L464-L464, and ui/src/locales/ru/containerComponents.json#L464-L464. Keep the key only in the authoritative English catalog ui/src/locales/en/containerComponents.json and do not add replacement English values to non-English catalogs.Source: Learnings
π€ Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/watchers/providers/docker/maintenance.ts`:
- Around line 57-62: Update hasNarrowMinuteField to parse the cron expression
with node-cron and inspect the actual minute field, avoiding classification of
the optional seconds field in six-field expressions; ensure broad ranges such as
0-59 are recognized as non-narrow while preserving false for empty input.
In `@content/docs/current/configuration/agents/index.mdx`:
- Line 77: Update the Edge Mode warning in
content/docs/current/configuration/agents/index.mdx:77-77 to require a VPN,
tunnel, or published endpoint that makes the standard agent reachable by the
controller before recommending it for update triggers. Apply the same
reachability requirement to the remediation steps in
content/docs/current/faq/index.mdx:482-486.
In `@content/docs/current/guides/security/index.mdx`:
- Around line 96-97: Update the documentation paragraph describing
portwing-with-exec.yaml to state that it only permits exec_* frames for an
external controller integration and does not make remote exec available through
Drydock, which has no end-user UI or API for opening exec sessions. Keep the
existing activation and policy-enforcement guidance unchanged.
In `@content/docs/current/monitoring/index.mdx`:
- Line 297: Update the `update-available` documentation statement to include
Drydock restarts as another condition that causes re-emission, reflecting that
in-memory signature state is cleared and an unchanged pending update is recorded
again after restart.
In `@scripts/security-dependency-versions.test.mjs`:
- Around line 41-54: Update the `fast-uri is pinned to a patched release in app
and ui` test to assert that each `manifest.overrides?.['fast-uri']` equals
`4.1.1` directly, removing acceptance of `3.1.4`; retain the existing
`isFastUriPatched(resolvedVersion(...))` assertion for the lockfile.
In `@ui/src/components/ConfirmDialog.vue`:
- Around line 77-86: Update handleKeydown to return early for anchors and other
native interactive controls before calling accept(), preserving their default
Enter behavior and allowing the documentation link rendered by the current.link
anchor to navigate normally.
In `@ui/src/locales/fr/appShell.json`:
- Line 50: Update the "light" label in the French appShell locale so it uses the
masculine form "Clair" instead of "Claire", preserving the existing theme
selector structure and surrounding translations.
In `@ui/src/locales/fr/containerComponents.json`:
- Line 463: Update the French softBlockerSuffix translation so the final
sentence describes overriding the policy rather than replacing the container,
while preserving the existing line breaks, placeholder, and surrounding
update-action meaning.
- Line 268: Update the "digest" translation in containerComponents.json to
preserve its Docker image digest meaning, matching the existing "Digest" label
rather than translating it as "RΓ©capitulatif".
- Around line 166-167: Update the French translations for tailCount and tailAll
in the container components locale to use wording for displaying the last log
lines, replacing the current queue-related terms while preserving the {count}
placeholder in tailCount.
- Around line 453-456: Update the forceUpdate.message translation to state that
only the skip and snooze policies are cleared before attempting the update,
rather than implying that all update policy is removed. Keep the existing
force-update confirmation meaning and the forceUpdate header and acceptLabel
unchanged.
In `@ui/src/locales/fr/listViews.json`:
- Around line 67-68: Remove the untranslated maturity-cleared entries from both
auditView.actions and notificationsView.rules in
ui/src/locales/fr/listViews.json (lines 67-68 and 111-114),
ui/src/locales/it/listViews.json (lines 67-68 and 111-114),
ui/src/locales/ja/listViews.json (lines 67-68 and 111-114),
ui/src/locales/ko/listViews.json (lines 67-68 and 111-114),
ui/src/locales/nl/listViews.json (lines 67-68 and 111-114),
ui/src/locales/pl/listViews.json (lines 67-68 and 111-114), and
ui/src/locales/pt-BR/listViews.json (lines 67-68 and 111-114). Leave the
authoritative English catalog unchanged so fallbackLocale supplies the value.
In `@ui/src/locales/ru/listViews.json`:
- Line 68: Remove the hand-seeded maturity-cleared entries from
ui/src/locales/ru/listViews.json, ui/src/locales/tr/listViews.json,
ui/src/locales/uk/listViews.json, ui/src/locales/vi/listViews.json,
ui/src/locales/zh-CN/listViews.json, and ui/src/locales/zh-TW/listViews.json at
lines 68 and 112-114. Remove softBlockerLearnMore from
ui/src/locales/ja/containerComponents.json,
ui/src/locales/ko/containerComponents.json, and
ui/src/locales/nl/containerComponents.json at line 464; leave ui/src/locales/en
authoritative and rely on fallbackLocale for missing non-English keys.
In `@ui/src/locales/tr/containerComponents.json`:
- Line 464: Remove the newly added softBlockerLearnMore key from
ui/src/locales/tr/containerComponents.json,
ui/src/locales/uk/containerComponents.json,
ui/src/locales/vi/containerComponents.json,
ui/src/locales/zh-CN/containerComponents.json, and
ui/src/locales/zh-TW/containerComponents.json. Remove
auditView.actions.maturity-cleared and notificationsView.rules.maturity-cleared
from ui/src/locales/ar/listViews.json, ui/src/locales/de/listViews.json, and
ui/src/locales/es/listViews.json. Leave the authoritative English catalogs
unchanged so fallbackLocale supplies these values.
---
Nitpick comments:
In `@ui/src/locales/fr/containerComponents.json`:
- Line 464: Remove the manually added softBlockerLearnMore entry from
ui/src/locales/fr/containerComponents.json#L464-L464,
ui/src/locales/ar/containerComponents.json#L464-L464,
ui/src/locales/de/containerComponents.json#L464-L464,
ui/src/locales/es/containerComponents.json#L464-L464,
ui/src/locales/it/containerComponents.json#L464-L464,
ui/src/locales/pt-BR/containerComponents.json#L464-L464,
ui/src/locales/pl/containerComponents.json#L464-L464, and
ui/src/locales/ru/containerComponents.json#L464-L464. Keep the key only in the
authoritative English catalog ui/src/locales/en/containerComponents.json and do
not add replacement English values to non-English catalogs.
πͺ Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
βΉοΈ Review info
βοΈ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: d80d3f99-8ff3-4c97-8280-56569251be5a
β Files ignored due to path filters (3)
CHANGELOG.mdis excluded by!CHANGELOG.mdapp/package-lock.jsonis excluded by!**/package-lock.json,!**/package-lock.jsonui/package-lock.jsonis excluded by!**/package-lock.json,!**/package-lock.json
π Files selected for processing (90)
README.mdapp/configuration/index.test.tsapp/configuration/index.tsapp/event/audit-subscriptions.test.tsapp/event/audit-subscriptions.tsapp/package.jsonapp/triggers/providers/docker/Docker.test.tsapp/triggers/providers/docker/Docker.tsapp/watchers/providers/docker/Docker.containers.additional-coverage-core.test.tsapp/watchers/providers/docker/Docker.containers.additional-coverage-helpers.test.tsapp/watchers/providers/docker/Docker.containers.test.tsapp/watchers/providers/docker/Docker.events.test.tsapp/watchers/providers/docker/Docker.test.tsapp/watchers/providers/docker/Docker.tsapp/watchers/providers/docker/Docker.watch.test.tsapp/watchers/providers/docker/maintenance.test.tsapp/watchers/providers/docker/maintenance.tsapps/demo/src/mocks/data/agents.tsapps/demo/src/mocks/data/audit.tsapps/demo/src/mocks/data/containers.tsapps/demo/src/mocks/data/server.tsapps/demo/src/mocks/handlers/app.tsapps/web/src/lib/site-config.tsapps/web/src/lib/site-content.tscontent/docs/current/api/agent.mdxcontent/docs/current/api/app.mdxcontent/docs/current/api/portwing.mdxcontent/docs/current/configuration/actions/update-eligibility.mdxcontent/docs/current/configuration/agents/index.mdxcontent/docs/current/configuration/self-update/index.mdxcontent/docs/current/configuration/server/index.mdxcontent/docs/current/configuration/watchers/index.mdxcontent/docs/current/faq/index.mdxcontent/docs/current/getting-started/index.mdxcontent/docs/current/guides/security/index.mdxcontent/docs/current/monitoring/index.mdxcontent/docs/current/quickstart/index.mdxcontent/docs/current/updates/index.mdxrenovate.jsonscripts/changelog-links.test.mjsscripts/release-docs-identity.test.mjsscripts/release-identity.test.mjsscripts/security-dependency-versions.test.mjstest/qa-compose.ymlui/package.jsonui/src/components/ConfirmDialog.vueui/src/composables/useConfirmDialog.tsui/src/composables/useUpdateStatus.tsui/src/locales/ar/containerComponents.jsonui/src/locales/ar/listViews.jsonui/src/locales/de/containerComponents.jsonui/src/locales/de/listViews.jsonui/src/locales/en/containerComponents.jsonui/src/locales/es/containerComponents.jsonui/src/locales/es/listViews.jsonui/src/locales/fr/agentsView.jsonui/src/locales/fr/appShell.jsonui/src/locales/fr/common.jsonui/src/locales/fr/configView.jsonui/src/locales/fr/containerComponents.jsonui/src/locales/fr/listViews.jsonui/src/locales/it/containerComponents.jsonui/src/locales/it/listViews.jsonui/src/locales/ja/containerComponents.jsonui/src/locales/ja/listViews.jsonui/src/locales/ko/containerComponents.jsonui/src/locales/ko/listViews.jsonui/src/locales/nl/containerComponents.jsonui/src/locales/nl/listViews.jsonui/src/locales/pl/containerComponents.jsonui/src/locales/pl/listViews.jsonui/src/locales/pt-BR/containerComponents.jsonui/src/locales/pt-BR/listViews.jsonui/src/locales/ru/containerComponents.jsonui/src/locales/ru/listViews.jsonui/src/locales/tr/containerComponents.jsonui/src/locales/tr/listViews.jsonui/src/locales/uk/containerComponents.jsonui/src/locales/uk/listViews.jsonui/src/locales/vi/containerComponents.jsonui/src/locales/vi/listViews.jsonui/src/locales/zh-CN/containerComponents.jsonui/src/locales/zh-CN/listViews.jsonui/src/locales/zh-TW/containerComponents.jsonui/src/locales/zh-TW/listViews.jsonui/src/views/DashboardView.vueui/src/views/containers/useContainerActions.tsui/tests/components/ConfirmDialog.spec.tsui/tests/views/DashboardView.spec.tsui/tests/views/containers/useContainerActions.spec.ts
π€ Files with no reviewable changes (3)
- content/docs/current/configuration/server/index.mdx
- app/configuration/index.ts
- app/configuration/index.test.ts
Comment on lines
+57
to
+62
| export function hasNarrowMinuteField(cronExpr: string): boolean { | ||
| if (!cronExpr) { | ||
| return false; | ||
| } | ||
| const minuteField = cronExpr.trim().split(/\s+/)[0]; | ||
| return !minuteField?.includes('*'); |
There was a problem hiding this comment.
π― Functional Correctness | π‘ Minor | β‘ Quick win
𧩠Analysis chain
π Script executed:
#!/bin/bash
set -euo pipefail
echo "== locate file =="
git ls-files | grep -F 'app/watchers/providers/docker/maintenance.ts' || true
echo "== relevant source =="
if [ -f app/watchers/providers/docker/maintenance.ts ]; then
nl -ba app/watchers/providers/docker/maintenance.ts | sed -n '1,140p'
fi
echo "== usages of hasNarrowMinuteField =="
rg -n "hasNarrowMinuteField|NarrowMinuteField|narrow" app/test app tests -S || true
echo "== package manifests with node-cron =="
rg -n "node-cron|cron-parser|cron" package.json pnpm-lock.yaml package-lock.json yarn.lock bun.lockb app/package.json 2>/dev/null || trueRepository: CodesWhat/drydock
Length of output: 280
π Script executed:
#!/bin/bash
set -euo pipefail
echo "== relevant source =="
awk '{printf "%6d\t%s\n", NR, $0}' app/watchers/providers/docker/maintenance.ts | sed -n '1,160p'
echo "== usages of hasNarrowMinuteField =="
rg -n "hasNarrowMinuteField|NarrowMinuteField|narrow" app/test app tests -S || true
echo "== package manifests with cron deps =="
for f in package.json pnpm-lock.yaml package-lock.json yarn.lock bun.lockb app/package.json; do
if [ -f "$f" ]; then
echo "--- $f ---"
rg -n "node-cron|cron-parser|cron" "$f" || true
fi
done
echo "== package manager availability =="
(command -v node && node --version) || true
(command -v npm && npm --version) || true
(command -v pnpm && pnpm --version) || true
(command -v npx && npx --version) || trueRepository: CodesWhat/drydock
Length of output: 8385
π Script executed:
#!/bin/bash
set -euo pipefail
echo "== maintenance tests =="
awk '{printf "%6d\t%s\n", NR, $0}' app/watchers/providers/docker/maintenance.test.ts | sed -n '1,170p'
echo "== watcher call site =="
awk '{printf "%6d\t%s\n", NR, $0}' app/watchers/providers/docker/Docker.ts | sed -n '620,735p'
echo "== installed node-cron package availability =="
node - <<'JS'
try {
const path = require.resolve('node-cron');
console.log("RESOLVED_PATH", path);
} catch (error) {
console.log("NOT_RESOLVED", error.message);
process.exit(0);
}
const cron = require('node-cron');
const cases = ['0-59 * * * *', '*/1 * * * *', '* * * * *', '59 * * * *'];
for (const expr of cases) {
console.log({ expr, valid: cron.validate(expr), parsed: cron.parse(expr) });
}
JS
echo "== cron-parser available and field count semantics =="
for pkg in cron-parser joi-cron-expression node-cron; do
echo "--- $pkg ---"
node - <<JS
try {
const path = require.resolve('$pkg');
console.log("RESOLVED_PATH", path);
} catch {
console.log("NOT_RESOLVED");
process.exit(0);
}
const lib = require('$pkg');
console.log(JSON.stringify(lib.parseExpression('0-59 * * * *', { includeLocals: false })?.fields, null, 2).substring(0, 1200));
JS
done
echo "== local npm dependency availability in repo cache =="
node - <<'JS'
for (const name of ['node-cron', 'cron-parser', 'joi-cron-expression']) {
try {
console.log(name + ' = ' + require(name) && typeof require(name));
} catch (error) {
console.log(name + ' unavailable');
}
}
JSRepository: CodesWhat/drydock
Length of output: 12429
π Web query:
node-cron 4.6.0 validate accepts six field cron seconds field documentation
π‘ Result:
Yes, in node-cron version 4.6.0, the validate function accepts both 5-field and 6-field cron expressions [1][2]. The 6-field format includes an optional seconds field at the beginning [3][4][5]. Key details regarding validation in node-cron 4.6.0: - Supported Format: The library supports a standard cron syntax that optionally allows for a leading seconds field (0-59) [3][4]. - Validation Logic: The validate function checks the expression for syntactic correctness and ensures the field count is either 5 or 6 [1][2]. Versions prior to 4.6.0 contained bugs where validate might ignore incorrect field counts or disagree with other validation methods; these were addressed in the 4.6.0 release to ensure consistent validation logic [6][1]. - API Options: - validate(expression): Returns a boolean (true if valid, false otherwise) [7]. - validateDetailed(expression): Returns a structured object containing validation status, field-specific error details (if any), and parsed field information [7][2]. - Parsing: When using 6-field expressions, the first field is explicitly treated as the seconds field (0-59) [3][4]. If you are building tools or need granular feedback on why a specific cron expression is invalid, it is recommended to use validateDetailed [7][2].
Citations:
- 1: fix: validate() consistency and multi-asterisk expansionΒ node-cron/node-cron#606
- 2: feat: cron.parse and cron.validateDetailed (expression introspection)Β node-cron/node-cron#548
- 3: https://github.com/node-cron/node-cron
- 4: https://github.com/node-cron/node-cron/blob/main/README.md
- 5: https://tool.crontap.com/node-cron
- 6: https://github.com/node-cron/node-cron/releases/tag/v4.6.0
- 7: https://www.nodecron.com/api-reference.html
π Web query:
node-cron parse cron expression fields seconds minute hour day month day of week
π‘ Result:
The node-cron library supports both 5-field and 6-field cron expressions [1][2]. The leading seconds field is optional; when it is omitted (5-field syntax), it defaults to 0, meaning the task executes at the start of the specified minute [1][3]. The fields are parsed in the following order: 1. Second: 0-59 (Optional) [1][4] 2. Minute: 0-59 [1][4] 3. Hour: 0-23 [1][4] 4. Day of Month: 1-31 (supports modifiers like L, W, LW, and L-n) [1][2] 5. Month: 1-12 (or names like Jan, Feb) [1][4] 6. Day of Week: 0-7 (0 and 7 are Sunday; also supports names and modifiers like # and L) [1][2] Note that while node-cron borrows several modifiers from the Quartz scheduler (such as L, W, and #), it is not fully Quartz-compatible [2][4]. Specifically, in node-cron, the day-of-month and day-of-week fields are combined with an AND logic, whereas Quartz treats them as mutually exclusive [2][4]. Additionally, day-of-week numbering follows the standard cron convention where 0 or 7 represents Sunday, unlike Quartz where 1 represents Sunday [2][4]. For verification or programmatic parsing, the library provides a parse function that returns a structured object of the defined fields or throws an error for invalid expressions [5].
Citations:
- 1: https://www.nodecron.com/cron-syntax.html
- 2: https://github.com/node-cron/node-cron
- 3: https://github.com/kelektiv/node-cron?tab=readme-ov-file
- 4: https://github.com/node-cron/node-cron/blob/main/README.md
- 5: https://www.nodecron.com/api-reference.html
π Script executed:
#!/bin/bash
set -euo pipefail
tmp="$(mktemp -d)"
cd "$tmp"
pkg="node-cron@4.6.0"
echo "== package metadata =="
npm view "$pkg" version main exports type --json 2>/dev/null || true
echo "== tarball files containing examples/tests =="
npm view "$pkg" dist.tarball > "$tmp/tarball.txt"
tarball="$(cat "$tmp/tarball.txt")"
curl -fsSL "$tarball" -o "$tmp/package.tgz"
tar -tzf "$tmp/package.tgz" | grep -E '(README|test|example|dist|src).*\.md$|(\.js|\.ts)$' | head -100
echo "== node-cron README cron syntax excerpts =="
tar -xzf "$tmp/package.tgz"
find package -maxdepth 3 -type f | sort | head -40
rg -n "six field|5 field|seconds|Validate|parseExpression|parseDetailed" package README.md package/README.md 2>/dev/null || true
echo "== package lock exact version =="
if [ -f package/package.json ]; then
jq '.version // empty' package/package.json 2>/dev/null || true
fiRepository: CodesWhat/drydock
Length of output: 50373
Compute whether the minute field is narrow by parsing the cron shape.
hasNarrowMinuteField() looks only at the first token, so 0-59 * * * * is reported as narrow and triggers a false warning. With node-cron accepting 6-field expressions, this also treats the optional seconds field as the minute field. For 5-field input, use cron.parse(expression).fields[0]; for 6-field input use the minute field, or enforce exactly five tokens before token-based checks.
π€ Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@app/watchers/providers/docker/maintenance.ts` around lines 57 - 62, Update
hasNarrowMinuteField to parse the cron expression with node-cron and inspect the
actual minute field, avoiding classification of the optional seconds field in
six-field expressions; ensure broad ranges such as 0-59 are recognized as
non-narrow while preserving false for empty input.
|
|
||
| <Callout type="info">**Container logs work continuously over the authenticated edge tunnel.** Live viewers receive separate stdout/stderr chunks, may request timestamps, and cancel the upstream Docker stream when the viewer closes. Both ends enforce bounded queues so a stalled viewer or controller is disconnected instead of growing memory without limit. Older Portwing agents fall back to the bounded one-shot log response, so mixed-version fleets degrade gracefully.</Callout> | ||
|
|
||
| <Callout type="warn">**Update triggers are not yet proxied over Edge Mode.** `docker` and `dockercompose` action triggers only run on a standard (inbound HTTP) agent today β Edge Mode currently proxies discovery/watch state, continuous container logs, and container delete, but not update triggers. If you need to update containers on a NAT'd/firewalled host, configure it as a standard agent instead.</Callout> |
There was a problem hiding this comment.
π― Functional Correctness | π Major | β‘ Quick win
State the required controller-to-agent network path.
Edge Mode exists for agents that cannot accept inbound controller requests. Both documents direct those operators to a standard inbound HTTP agent without stating that they must first make the agent reachable.
content/docs/current/configuration/agents/index.mdx#L77-L77: require a VPN, tunnel, or published endpoint before recommending a standard agent for update triggers.content/docs/current/faq/index.mdx#L482-L486: add the same reachability requirement to the remediation steps.
π Affects 2 files
content/docs/current/configuration/agents/index.mdx#L77-L77(this comment)content/docs/current/faq/index.mdx#L482-L486
π€ Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@content/docs/current/configuration/agents/index.mdx` at line 77, Update the
Edge Mode warning in content/docs/current/configuration/agents/index.mdx:77-77
to require a VPN, tunnel, or published endpoint that makes the standard agent
reachable by the controller before recommending it for update triggers. Apply
the same reachability requirement to the remediation steps in
content/docs/current/faq/index.mdx:482-486.
Source: Path instructions
Comment on lines
+96
to
+97
| sockguard also ships a separate [`portwing-with-exec.yaml`](https://github.com/CodesWhat/sockguard/blob/dev/v1.5/app/configs/portwing-with-exec.yaml) preset for deployments that need remote exec through the Edge agent (see the [exec session protocol](/docs/api/portwing#exec-session-protocol)). To activate it, replace the preset file the compose example mounts (swap `sockguard.yaml` for a copy of `portwing-with-exec.yaml`, or point the sockguard service's config mount at it) and restart sockguard β merely having the file present changes nothing, and the default preset above denies all exec. Exec authorization β privileged/root escalation and per-command allowlisting β is enforced by sockguard's exec policy, not by drydock. | ||
|
|
There was a problem hiding this comment.
π Security & Privacy | π Major | β‘ Quick win
Document that this preset does not enable a Drydock feature.
Drydock v1.6 has no end-user UI or API that opens an exec session. This text can cause operators to enable an exec-permissive sockguard policy for an unavailable feature. State that the preset only permits exec_* frames for an external controller integration and does not make remote exec available through Drydock.
π€ Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@content/docs/current/guides/security/index.mdx` around lines 96 - 97, Update
the documentation paragraph describing portwing-with-exec.yaml to state that it
only permits exec_* frames for an external controller integration and does not
make remote exec available through Drydock, which has no end-user UI or API for
opening exec sessions. Keep the existing activation and policy-enforcement
guidance unchanged.
Source: Path instructions
| Use the audit API (`/api/v1/audit`) and Audit UI view to track runtime events alongside metrics. Current event coverage includes: | ||
|
|
||
| - `update-available` on a new update transition or changed target. Repeated identical watcher reports are deduplicated for one hour by default; configure the window with `DD_AUDIT_UPDATE_AVAILABLE_DEDUPE_MS`. | ||
| - `update-available` on first detection, on a change of the update target, or on re-detection after the update resolves or the container is removed/recreated. Unchanged updates are never re-asserted just because time has passed. |
There was a problem hiding this comment.
π― Functional Correctness | π‘ Minor | β‘ Quick win
Document re-emission after a Drydock restart.
The runtime clears the in-memory signature state on restart. The next unchanged pending update records another update-available audit. Add βor Drydock restartsβ to this condition.
Proposed correction
-- `update-available` on first detection, on a change of the update target, or on re-detection after the update resolves or the container is removed/recreated. Unchanged updates are never re-asserted just because time has passed.
+- `update-available` on first detection, on a change of the update target, or on re-detection after the update resolves, the container is removed/recreated, or Drydock restarts. Unchanged updates are never re-asserted just because time has passed.As per path instructions, βDocumentation content. Review for accuracy against the code, not prose style.β
π Committable suggestion
βΌοΈ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - `update-available` on first detection, on a change of the update target, or on re-detection after the update resolves or the container is removed/recreated. Unchanged updates are never re-asserted just because time has passed. | |
| - `update-available` on first detection, on a change of the update target, or on re-detection after the update resolves, the container is removed/recreated, or Drydock restarts. Unchanged updates are never re-asserted just because time has passed. |
π€ Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@content/docs/current/monitoring/index.mdx` at line 297, Update the
`update-available` documentation statement to include Drydock restarts as
another condition that causes re-emission, reflecting that in-memory signature
state is cleared and an unchanged pending update is recorded again after
restart.
Source: Path instructions
Comment on lines
+41
to
+54
| // fast-uri was pinned to 3.1.4 in app/ and ui/ for CVE-2026-16221 | ||
| // (GHSA-v2hh-gcrm-f6hx). 4.1.1 retains the fix, and Renovate's override | ||
| // bump to 4.1.1 (#617) is accepted alongside the original pin below. | ||
| // Transitional: drop the 3.1.4 branch once #617 lands. | ||
| test('fast-uri is pinned to a patched release in app and ui', () => { | ||
| for (const workspace of ['app', 'ui']) { | ||
| const manifest = readJson(`${workspace}/package.json`); | ||
| const lockfile = readJson(`${workspace}/package-lock.json`); | ||
|
|
||
| assert.equal(manifest.overrides?.['fast-uri'], '3.1.4', `${workspace} override`); | ||
| assert.ok( | ||
| compareSemver(resolvedVersion(lockfile, 'fast-uri'), '3.1.4') >= 0, | ||
| `${workspace} lockfile`, | ||
| ['3.1.4', '4.1.1'].includes(manifest.overrides?.['fast-uri']), | ||
| `${workspace} override`, | ||
| ); | ||
| assert.ok(isFastUriPatched(resolvedVersion(lockfile, 'fast-uri')), `${workspace} lockfile`); |
There was a problem hiding this comment.
π― Functional Correctness | π‘ Minor | β‘ Quick win
𧩠Analysis chain
π Script executed:
#!/bin/bash
set -euo pipefail
echo "Tracked files of interest:"
git ls-files | rg '(^|/)(package\.json|package-lock\.json|security-dependency-versions\.test\.mjs)$' || true
echo
echo "Relevant test lines:"
sed -n '1,100p' scripts/security-dependency-versions.test.mjs 2>/dev/null || true
echo
echo "Package override references:"
for f in app/package.json ui/package.json; do
if [ -f "$f" ]; then
echo "--- $f ---"
rg -n '"fast-uri"|"overrides"' "$f" -C 3 || true
fi
done
echo
echo "Lockfile fast-uri mentions (brief):"
for f in app/package-lock.json ui/package-lock.json; do
if [ -f "$f" ]; then
echo "--- $f ---"
rg -n '"name": "fast-uri"|"fast-uri"|version' "$f" -C 2 | head -80 || true
fi
doneRepository: CodesWhat/drydock
Length of output: 13055
Use the expected fast-uri override directly.
Both workspaces now set manifest.overrides?.['fast-uri'] to 4.1.1, but the test still accepts 3.1.4. Assert the pinned value from each manifest, then keep isFastUriPatched to validate the resolved lockfile version.
Proposed fix
- ['3.1.4', '4.1.1'].includes(manifest.overrides?.['fast-uri']),
+ manifest.overrides?.['fast-uri'] === '4.1.1',π Committable suggestion
βΌοΈ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| // fast-uri was pinned to 3.1.4 in app/ and ui/ for CVE-2026-16221 | |
| // (GHSA-v2hh-gcrm-f6hx). 4.1.1 retains the fix, and Renovate's override | |
| // bump to 4.1.1 (#617) is accepted alongside the original pin below. | |
| // Transitional: drop the 3.1.4 branch once #617 lands. | |
| test('fast-uri is pinned to a patched release in app and ui', () => { | |
| for (const workspace of ['app', 'ui']) { | |
| const manifest = readJson(`${workspace}/package.json`); | |
| const lockfile = readJson(`${workspace}/package-lock.json`); | |
| assert.equal(manifest.overrides?.['fast-uri'], '3.1.4', `${workspace} override`); | |
| assert.ok( | |
| compareSemver(resolvedVersion(lockfile, 'fast-uri'), '3.1.4') >= 0, | |
| `${workspace} lockfile`, | |
| ['3.1.4', '4.1.1'].includes(manifest.overrides?.['fast-uri']), | |
| `${workspace} override`, | |
| ); | |
| assert.ok(isFastUriPatched(resolvedVersion(lockfile, 'fast-uri')), `${workspace} lockfile`); | |
| // fast-uri was pinned to 3.1.4 in app/ and ui/ for CVE-2026-16221 | |
| // (GHSA-v2hh-gcrm-f6hx). 4.1.1 retains the fix, and Renovate's override | |
| // bump to 4.1.1 (`#617`) is accepted alongside the original pin below. | |
| // Transitional: drop the 3.1.4 branch once `#617` lands. | |
| test('fast-uri is pinned to a patched release in app and ui', () => { | |
| for (const workspace of ['app', 'ui']) { | |
| const manifest = readJson(`${workspace}/package.json`); | |
| const lockfile = readJson(`${workspace}/package-lock.json`); | |
| assert.ok( | |
| manifest.overrides?.['fast-uri'] === '4.1.1', | |
| `${workspace} override`, | |
| ); | |
| assert.ok(isFastUriPatched(resolvedVersion(lockfile, 'fast-uri')), `${workspace} lockfile`); |
π€ Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@scripts/security-dependency-versions.test.mjs` around lines 41 - 54, Update
the `fast-uri is pinned to a patched release in app and ui` test to assert that
each `manifest.overrides?.['fast-uri']` equals `4.1.1` directly, removing
acceptance of `3.1.4`; retain the existing
`isFastUriPatched(resolvedVersion(...))` assertion for the lockfile.
Comment on lines
453
to
+456
| "forceUpdate": { | ||
| "header": "Force Update", | ||
| "message": "Force update {name}? This clears skip/snooze policy before attempting update.", | ||
| "acceptLabel": "Force Update" | ||
| "header": "Forcer la Mise Γ jour", | ||
| "message": "Forcer la mise Γ jour de {name} ? Cela supprime la politique de mise Γ jour avant d'essayer de mettre Γ jour.", | ||
| "acceptLabel": "Forcer la Mise Γ jour" |
There was a problem hiding this comment.
π― Functional Correctness | π‘ Minor | β‘ Quick win
Preserve the force-update policy scope.
The runtime clears skip and snooze policy. "supprime la politique de mise Γ jour" implies that all update policy is removed.
Proposed translation
- "message": "Forcer la mise Γ jour de {name} ? Cela supprime la politique de mise Γ jour avant d'essayer de mettre Γ jour.",
+ "message": "Forcer la mise Γ jour de {name} ? Cela efface les paramΓ¨tres d'ignorance et de report avant de tenter la mise Γ jour.",π Committable suggestion
βΌοΈ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "forceUpdate": { | |
| "header": "Force Update", | |
| "message": "Force update {name}? This clears skip/snooze policy before attempting update.", | |
| "acceptLabel": "Force Update" | |
| "header": "Forcer la Mise Γ jour", | |
| "message": "Forcer la mise Γ jour de {name} ? Cela supprime la politique de mise Γ jour avant d'essayer de mettre Γ jour.", | |
| "acceptLabel": "Forcer la Mise Γ jour" | |
| "forceUpdate": { | |
| "header": "Forcer la Mise Γ jour", | |
| "message": "Forcer la mise à jour de {name} ? Cela efface les paramètres d'ignorance et de report avant de tenter la mise à jour.", | |
| "acceptLabel": "Forcer la Mise Γ jour" |
π€ Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ui/src/locales/fr/containerComponents.json` around lines 453 - 456, Update
the forceUpdate.message translation to state that only the skip and snooze
policies are cleared before attempting the update, rather than implying that all
update policy is removed. Keep the existing force-update confirmation meaning
and the forceUpdate header and acceptLabel unchanged.
| "messageLatest": "Mettre Γ jour {name} maintenant ? L'image la plus rΓ©cente dΓ©tectΓ©e sera appliquΓ©e.", | ||
| "messageTagChange": "Mettre Γ jour {name} ? Le tag d'image passera de :{currentTag} Γ :{newTag}{kind}.", | ||
| "messageDigestChange": "Mettre Γ jour {name} ? Un build plus rΓ©cent de :{currentTag} est disponible (changement de rΓ©capitulatif).", | ||
| "softBlockerSuffix": "\n\nCette mise Γ jour est actuellement bloquΓ©e par la politique :\n{list}\n\nCliquez sur Mettre Γ jour quand mΓͺme pour remplacer.", |
There was a problem hiding this comment.
π― Functional Correctness | π‘ Minor | β‘ Quick win
Translate the policy override, not container replacement.
The action overrides a policy gate. pour remplacer changes the meaning.
Proposed translation
- "softBlockerSuffix": "\n\nCette mise Γ jour est actuellement bloquΓ©e par la politique :\n{list}\n\nCliquez sur Mettre Γ jour quand mΓͺme pour remplacer.",
+ "softBlockerSuffix": "\n\nCette mise Γ jour est actuellement bloquΓ©e par la politique :\n{list}\n\nCliquez sur Β« Mettre Γ jour quand mΓͺme Β» pour contourner la politique.",π Committable suggestion
βΌοΈ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "softBlockerSuffix": "\n\nCette mise Γ jour est actuellement bloquΓ©e par la politique :\n{list}\n\nCliquez sur Mettre Γ jour quand mΓͺme pour remplacer.", | |
| "softBlockerSuffix": "\n\nCette mise Γ jour est actuellement bloquΓ©e par la politique :\n{list}\n\nCliquez sur Β« Mettre Γ jour quand mΓͺme Β» pour contourner la politique.", |
π€ Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ui/src/locales/fr/containerComponents.json` at line 463, Update the French
softBlockerSuffix translation so the final sentence describes overriding the
policy rather than replacing the container, while preserving the existing line
breaks, placeholder, and surrounding update-action meaning.
Comment on lines
+67
to
+68
| "security-alert": "Alerte de sΓ©curitΓ©", | ||
| "maturity-cleared": "Maturity Cleared" |
There was a problem hiding this comment.
π― Functional Correctness | π‘ Minor | β‘ Quick win
Remove the untranslated maturity-cleared entries from the Crowdin-managed catalogs.
Each listed locale adds English maturity-cleared values in both the audit action and notification rule. Remove these entries and let fallbackLocale use the authoritative English catalog until Crowdin supplies translations.
ui/src/locales/fr/listViews.json#L67-L68: removeauditView.actions["maturity-cleared"].ui/src/locales/fr/listViews.json#L111-L114: removenotificationsView.rules["maturity-cleared"].ui/src/locales/it/listViews.json#L67-L68: removeauditView.actions["maturity-cleared"].ui/src/locales/it/listViews.json#L111-L114: removenotificationsView.rules["maturity-cleared"].ui/src/locales/ja/listViews.json#L67-L68: removeauditView.actions["maturity-cleared"].ui/src/locales/ja/listViews.json#L111-L114: removenotificationsView.rules["maturity-cleared"].ui/src/locales/ko/listViews.json#L67-L68: removeauditView.actions["maturity-cleared"].ui/src/locales/ko/listViews.json#L111-L114: removenotificationsView.rules["maturity-cleared"].ui/src/locales/nl/listViews.json#L67-L68: removeauditView.actions["maturity-cleared"].ui/src/locales/nl/listViews.json#L111-L114: removenotificationsView.rules["maturity-cleared"].ui/src/locales/pl/listViews.json#L67-L68: removeauditView.actions["maturity-cleared"].ui/src/locales/pl/listViews.json#L111-L114: removenotificationsView.rules["maturity-cleared"].ui/src/locales/pt-BR/listViews.json#L67-L68: removeauditView.actions["maturity-cleared"].ui/src/locales/pt-BR/listViews.json#L111-L114: removenotificationsView.rules["maturity-cleared"].
Based on learnings, ui/src/locales/en/ is authoritative and non-English catalogs must not hand-seed new keys.
π Affects 7 files
ui/src/locales/fr/listViews.json#L67-L68(this comment)ui/src/locales/fr/listViews.json#L111-L114ui/src/locales/it/listViews.json#L67-L68ui/src/locales/it/listViews.json#L111-L114ui/src/locales/ja/listViews.json#L67-L68ui/src/locales/ja/listViews.json#L111-L114ui/src/locales/ko/listViews.json#L67-L68ui/src/locales/ko/listViews.json#L111-L114ui/src/locales/nl/listViews.json#L67-L68ui/src/locales/nl/listViews.json#L111-L114ui/src/locales/pl/listViews.json#L67-L68ui/src/locales/pl/listViews.json#L111-L114ui/src/locales/pt-BR/listViews.json#L67-L68ui/src/locales/pt-BR/listViews.json#L111-L114
π€ Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ui/src/locales/fr/listViews.json` around lines 67 - 68, Remove the
untranslated maturity-cleared entries from both auditView.actions and
notificationsView.rules in ui/src/locales/fr/listViews.json (lines 67-68 and
111-114), ui/src/locales/it/listViews.json (lines 67-68 and 111-114),
ui/src/locales/ja/listViews.json (lines 67-68 and 111-114),
ui/src/locales/ko/listViews.json (lines 67-68 and 111-114),
ui/src/locales/nl/listViews.json (lines 67-68 and 111-114),
ui/src/locales/pl/listViews.json (lines 67-68 and 111-114), and
ui/src/locales/pt-BR/listViews.json (lines 67-68 and 111-114). Leave the
authoritative English catalog unchanged so fallbackLocale supplies the value.
Source: Learnings
| "notification-delivery-failed": "ΠΡΠΈΠ±ΠΊΠ° Π΄ΠΎΡΡΠ°Π²ΠΊΠΈ ΡΠ²Π΅Π΄ΠΎΠΌΠ»Π΅Π½ΠΈΡ", | ||
| "security-alert": "ΠΡΠ΅Π΄ΡΠΏΡΠ΅ΠΆΠ΄Π΅Π½ΠΈΠ΅ Π±Π΅Π·ΠΎΠΏΠ°ΡΠ½ΠΎΡΡΠΈ" | ||
| "security-alert": "ΠΡΠ΅Π΄ΡΠΏΡΠ΅ΠΆΠ΄Π΅Π½ΠΈΠ΅ Π±Π΅Π·ΠΎΠΏΠ°ΡΠ½ΠΎΡΡΠΈ", | ||
| "maturity-cleared": "Maturity Cleared" |
There was a problem hiding this comment.
π Maintainability & Code Quality | π‘ Minor | β‘ Quick win
Keep new translation keys in the English catalog only.
These changes manually add new keys to non-English Crowdin-managed catalogs and seed English placeholder text. Remove the new keys from the translated catalogs and rely on fallbackLocale until Crowdin supplies localized values.
ui/src/locales/ru/listViews.json#L68-L68: removematurity-clearedat Lines [68] and [112]-[114].ui/src/locales/tr/listViews.json#L68-L68: removematurity-clearedat Lines [68] and [112]-[114].ui/src/locales/uk/listViews.json#L68-L68: removematurity-clearedat Lines [68] and [112]-[114].ui/src/locales/vi/listViews.json#L68-L68: removematurity-clearedat Lines [68] and [112]-[114].ui/src/locales/zh-CN/listViews.json#L68-L68: removematurity-clearedat Lines [68] and [112]-[114].ui/src/locales/zh-TW/listViews.json#L68-L68: removematurity-clearedat Lines [68] and [112]-[114].ui/src/locales/ja/containerComponents.json#L464-L464: removesoftBlockerLearnMoreat Line [464].ui/src/locales/ko/containerComponents.json#L464-L464: removesoftBlockerLearnMoreat Line [464].ui/src/locales/nl/containerComponents.json#L464-L464: removesoftBlockerLearnMoreat Line [464].
Based on learnings, ui/src/locales/en/ is authoritative, non-English catalogs must not hand-seed new keys, and missing keys fall back to English.
π Affects 9 files
ui/src/locales/ru/listViews.json#L68-L68(this comment)ui/src/locales/tr/listViews.json#L68-L68ui/src/locales/uk/listViews.json#L68-L68ui/src/locales/vi/listViews.json#L68-L68ui/src/locales/zh-CN/listViews.json#L68-L68ui/src/locales/zh-TW/listViews.json#L68-L68ui/src/locales/ja/containerComponents.json#L464-L464ui/src/locales/ko/containerComponents.json#L464-L464ui/src/locales/nl/containerComponents.json#L464-L464
π€ Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ui/src/locales/ru/listViews.json` at line 68, Remove the hand-seeded
maturity-cleared entries from ui/src/locales/ru/listViews.json,
ui/src/locales/tr/listViews.json, ui/src/locales/uk/listViews.json,
ui/src/locales/vi/listViews.json, ui/src/locales/zh-CN/listViews.json, and
ui/src/locales/zh-TW/listViews.json at lines 68 and 112-114. Remove
softBlockerLearnMore from ui/src/locales/ja/containerComponents.json,
ui/src/locales/ko/containerComponents.json, and
ui/src/locales/nl/containerComponents.json at line 464; leave ui/src/locales/en
authoritative and rely on fallbackLocale for missing non-English keys.
Source: Learnings
| "messageTagChange": "Update {name}? This will change the image tag from :{currentTag} to :{newTag}{kind}.", | ||
| "messageDigestChange": "Update {name}? A newer build of :{currentTag} is available (digest change).", | ||
| "softBlockerSuffix": "\n\nThis update is currently policy-blocked:\n{list}\n\nClick Update anyway to override.", | ||
| "softBlockerLearnMore": "Learn more", |
There was a problem hiding this comment.
π Maintainability & Code Quality | π‘ Minor | β‘ Quick win
Remove new keys from non-English Crowdin catalogs.
Keep these keys in the English catalogs only. Let fallbackLocale provide English values until Crowdin supplies translations.
ui/src/locales/tr/containerComponents.json#L464-L464: removecontainerComponents.confirmDialogs.update.softBlockerLearnMore.ui/src/locales/uk/containerComponents.json#L464-L464: removecontainerComponents.confirmDialogs.update.softBlockerLearnMore.ui/src/locales/vi/containerComponents.json#L464-L464: removecontainerComponents.confirmDialogs.update.softBlockerLearnMore.ui/src/locales/zh-CN/containerComponents.json#L464-L464: removecontainerComponents.confirmDialogs.update.softBlockerLearnMore.ui/src/locales/zh-TW/containerComponents.json#L464-L464: removecontainerComponents.confirmDialogs.update.softBlockerLearnMore.ui/src/locales/ar/listViews.json#L68-L68: removeauditView.actions.maturity-cleared.ui/src/locales/ar/listViews.json#L112-L114: removenotificationsView.rules.maturity-cleared.ui/src/locales/de/listViews.json#L68-L68: removeauditView.actions.maturity-cleared.ui/src/locales/de/listViews.json#L112-L114: removenotificationsView.rules.maturity-cleared.ui/src/locales/es/listViews.json#L68-L68: removeauditView.actions.maturity-cleared.ui/src/locales/es/listViews.json#L112-L114: removenotificationsView.rules.maturity-cleared.
Based on learnings, ui/src/locales/en/ is authoritative and non-English catalogs are Crowdin-managed; do not hand-seed new translation keys.
π Affects 8 files
ui/src/locales/tr/containerComponents.json#L464-L464(this comment)ui/src/locales/uk/containerComponents.json#L464-L464ui/src/locales/vi/containerComponents.json#L464-L464ui/src/locales/zh-CN/containerComponents.json#L464-L464ui/src/locales/zh-TW/containerComponents.json#L464-L464ui/src/locales/ar/listViews.json#L68-L68ui/src/locales/ar/listViews.json#L112-L114ui/src/locales/de/listViews.json#L68-L68ui/src/locales/de/listViews.json#L112-L114ui/src/locales/es/listViews.json#L68-L68ui/src/locales/es/listViews.json#L112-L114
π€ Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ui/src/locales/tr/containerComponents.json` at line 464, Remove the newly
added softBlockerLearnMore key from ui/src/locales/tr/containerComponents.json,
ui/src/locales/uk/containerComponents.json,
ui/src/locales/vi/containerComponents.json,
ui/src/locales/zh-CN/containerComponents.json, and
ui/src/locales/zh-TW/containerComponents.json. Remove
auditView.actions.maturity-cleared and notificationsView.rules.maturity-cleared
from ui/src/locales/ar/listViews.json, ui/src/locales/de/listViews.json, and
ui/src/locales/es/listViews.json. Leave the authoritative English catalogs
unchanged so fallbackLocale supplies these values.
Source: Learnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard pre-cut sync. Brings main level with dev/v1.6 for the v1.6.0-rc.10 cut.
Delta since the rc.9 sync: #640, #641, #642, #614, #615, #645 (fixes #644), #620, #646, #617, #647 (release prep).
After merge, main's tree must equal origin/dev/v1.6 (squash-merge policy mints a new SHA; tree equality is the invariant the release-cut workflow asserts).
Changelog
update-availablededuplication to use stable signatures instead of a configurable time window.1.6.0-rc.10.Concerns
mainandorigin/dev/v1.6have identical trees after merge.DD_AUDIT_UPDATE_AVAILABLE_DEDUPE_MSis reflected in deployment configuration and upgrade guidance.