🐛 fix(ui): unclip the row-overlay chip and keep tags visible on registry errors - #631
Merged
Merged
Conversation
…try errors - 🐛 fix(ui): lift the overlay-host cell above its sticky z-10 row siblings while an updating/scanning overlay is active — the pinned identity cluster painted over the centered chip and clipped it at the cluster edge - ♻️ refactor(ui): drop the registry-error pill from the tag cell (table and card modes); the registry column warning glyph + tooltip is the single error flag and the container's actual tag stays visible - ✅ test(ui): update GroupedViews specs — tag renders during registry errors, pill absent
scttbnsn
requested review from
ALARGECOMPANY and
biggest-littlest
as code owners
July 28, 2026 21:29
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughContainer table and card views no longer render registry-error warning pills in tag/version areas. The table version cell consistently shows the current tag, optional pin glyph, update-reason badge, and policy-state icons; registry errors remain represented by warning glyphs. Tests now verify current-tag rendering without the rate-limit label. Updating and scanning overlay-host cells receive Possibly related PRs
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
scttbnsn
added a commit
that referenced
this pull request
Jul 28, 2026
Standard release-identity prep for **v1.6.0-rc.9** (same-day follow-up to rc.8), replicating the rc.8 prep (#626) pattern exactly: - CHANGELOG: `[Unreleased]` → `## [1.6.0-rc.9] — 2026-07-28` (keeps #630's Portwing edge-streaming entries, adds the two #631 UI fixes under Fixed), fresh empty `[Unreleased]`, link chain updated - 17-file identity bump: README badge/highlights, demo mocks, site-config/site-content, API doc samples, quickstart tag matrix, updates highlights section, pinned identity test constants (RC=1.6.0-rc.9, PREV=1.6.0-rc.8) - Version files stay at base `1.6.0` per the RC ritual Verified: 133/133 scripts tests, non-empty `extract-changelog-entry` body for v1.6.0-rc.9, no stale rc.8 identity outside deliberate history. Full local pre-push gate green. rc.9 delta over rc.8 = #630 (Portwing edge streaming default-on) + #631 (row-overlay chip clip fix, registry-error tag-cell fix). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Changelog - ✨ Added v1.6.0-rc.9 highlights covering Portwing edge log streaming and two UI fixes. - 🔧 Changed release identity references across documentation, demos, site content, API samples, quickstart data, and tests from rc.8 to rc.9. - 🔧 Changed changelog compare-link chain and added a fresh `[Unreleased]` section. - 🔧 Retained version files at base version `1.6.0`. - ✅ Verified 133 script tests, changelog extraction, stale rc.8 checks, and the full pre-push gate. ## Concerns - No runtime code changes are included. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
scttbnsn
added a commit
that referenced
this pull request
Jul 28, 2026
Wholesale-tree sync of `dev/v1.6` @ `3dc5f7b5` onto `main` ahead of the **v1.6.0-rc.9** cut. Delta over rc.8 (`bcbbf712`): - #630 — Portwing edge log streaming default-on (continuous WebSocket bridging, 1 MiB per-viewer caps, fleet-soak workflow) - #631 — UI: row-overlay chip unclipped at the pinned-column edge; registry errors no longer replace the tag in the tag column - #633 — rc.9 release-identity prep (CHANGELOG + 17-file bump) Head branch is a throwaway (`sync/main-20260728-rc9`) per the sync-PR pattern; the server-side commit's tree is exactly `dev/v1.6^{tree}` so `git diff origin/main origin/dev/v1.6` is empty after merge. Dispatch `release-cut.yml --ref main -f release_tag=v1.6.0-rc.9` once merged. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Changelog - ✨ Added continuous Portwing container-log streaming with cancellation, backpressure limits, legacy compatibility, and fleet-soak testing. - 🔧 Changed Portwing to enabled-by-default; `DD_EXPERIMENTAL_PORTWING=false` is now the emergency disable switch. - 🐛 Fixed pinned-column row-overlay clipping and registry errors overwriting container tags. - 🔧 Updated release identity and documentation from `v1.6.0-rc.8` to `v1.6.0-rc.9`. - ✨ Added release notes, API documentation, soak evidence reporting, and related test coverage. ## Concerns - Dispatch the release workflow with `release_tag=v1.6.0-rc.9` after merging. - Confirm the fleet-soak workflow succeeds and produces its evidence artifact. - Review Portwing memory, viewer-buffer, concurrency, and reconnect thresholds for production suitability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two dashboard/containers-table fixes from live-instance screenshots:
1. UPDATING/QUEUED/SCANNING overlay chip clipped at the sticky-cluster edge.
The pinned identity cluster cells are
sticky z-10and later in DOM order than the overlay-host cell, so they painted over the full-width row overlay and cut the centered chip in half ("UPDATING" rendered as "DATING"). While an overlay is active, the host cell now getsz-index: 11— above its z-10 row siblings, still below the z-20 sticky header.2. Registry errors no longer replace the tag in the tag column.
A rate-limit/auth/not-found registry error rendered a danger pill instead of the container's current tag (table mode) or appended one (card mode), duplicating the warning triangle + tooltip the registry column already shows. The tag cell now always shows the actual tag; the registry glyph stays the single error flag.
registryErrorPillLabelremoved; locale keys left in place.Specs updated accordingly (103/103 green, UI build clean).
HOLD: merge after v1.6.0 GA — runtime UI delta must not enter the GA tree (rc.8 is the promotion candidate).
✨ Added
🔧 Changed
z-index: 11.🗑️ Removed
Removed duplicate registry-error pills from table and card views.
103 tests pass and the UI build is clean.
Merge is held until after v1.6.0 GA.