🧪 test(ci): gate Playwright on fixture readiness#585
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
biggest-littlest
left a comment
biggest-littlest
left a comment
There was a problem hiding this comment.
The readiness contract matches the browser fixtures, keeps production watcher behavior untouched, and the cold-stack/full-suite proof covers the original race.
ALARGECOMPANY
left a comment
ALARGECOMPANY
left a comment
There was a problem hiding this comment.
Approved. Waiting for the startup scan instead of launching a competing scan is the right fix, and the no-retry Playwright proof is clean.
|
Warning Review limit reached
Next review available in: 13 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughPlaywright authentication now polls the containers API after login until a complete 29-container fixture snapshot is available. QA compose watchers use parked cron schedules, zero jitter, and disabled event refreshes. The workflow test verifies orchestration ordering, setup polling implementation, and watcher configuration. Reliability documentation records the startup race, mitigation, and cold-stack validation results. Possibly related PRs
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/cucumber-reliability.md`:
- Line 64: Update the readiness description to state that Playwright waits for
at least 29 containers, replacing the inaccurate “exact 29-container snapshot”
wording while preserving the rest of the documented behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 28ac98a2-4cad-456e-81f8-638f54c3f8fe
⛔ Files ignored due to path filters (1)
CHANGELOG.mdis excluded by!CHANGELOG.md
📒 Files selected for processing (4)
.github/tests/e2e-playwright-workflow.test.ts.github/workflows/e2e-playwright.ymldocs/cucumber-reliability.mdtest/qa-compose.yml
96bd6ea
c49f61a to
96bd6ea
Compare
biggest-littlest
left a comment
biggest-littlest
left a comment
There was a problem hiding this comment.
Re-reviewed the amended commit. Authenticated setup owns readiness now, Gitleaks is clean, and the final cold-stack browser run proves the exact path.
ALARGECOMPANY
left a comment
ALARGECOMPANY
left a comment
There was a problem hiding this comment.
Approved again after the history rewrite. The credential-free readiness gate and single-scan fixture stack are the right final shape.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@e2e/playwright/auth.setup.ts`:
- Around line 33-36: Update the container sentinel check in the auth setup flow
to compare against the fixture’s actual displayName, “Traefik,” instead of
“Traefik Proxy.” Preserve the existing dd.group infrastructure-label condition
and readiness behavior.
- Around line 59-77: Increase the timeout for the Playwright setup project in
playwright.config.ts, or configure the setup suite via setup.describe.configure,
to exceed the 180-second expect.poll window and accommodate login/setup waits.
Keep the existing global timeout unchanged for other projects.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 32996fbe-284c-4b1d-9718-3450aef69a91
⛔ Files ignored due to path filters (1)
CHANGELOG.mdis excluded by!CHANGELOG.md
📒 Files selected for processing (4)
.github/tests/e2e-playwright-workflow.test.tsdocs/cucumber-reliability.mde2e/playwright/auth.setup.tstest/qa-compose.yml
🚧 Files skipped from review as they are similar to previous changes (3)
- test/qa-compose.yml
- .github/tests/e2e-playwright-workflow.test.ts
- docs/cucumber-reliability.md
1506735
3 participants
What changed
/healthas fixture readinessWhy
The two exact-main attempts failed in different places because browser scenarios could start while watcher enrichment was still running. The second attempt passed the first failure, then hit partial group and update-result state. Launching an explicit scan is not the answer because it can overlap Drydock’s built-in startup scan; the authenticated setup now waits for that scan to finish and keeps the accepted snapshot stable. Production watcher defaults are unchanged.
Proof
Changelog
/healthpassing.Concerns