Skip to content

✅ test(e2e): align pinned-display and maturity-clock expectations with #566#573

Closed
scttbnsn wants to merge 1 commit into
dev/v1.6from
fix/v1.6-e2e-display-honesty
Closed

✅ test(e2e): align pinned-display and maturity-clock expectations with #566#573
scttbnsn wants to merge 1 commit into
dev/v1.6from
fix/v1.6-e2e-display-honesty

Conversation

@scttbnsn

@scttbnsn scttbnsn commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

The 🎭 E2E: Playwright job on release PR #572 caught two specs still asserting pre-#566 display behavior. Both are intentional changes from the display-honesty batch, not regressions:

Verified locally against the QA env (drydock:dev, :3333): all 4 tests in the spec pass.

Unblocks #572.

Changelog

  • 🔧 Changed maturity countdown assertions to expect unlocks wording with updated minute intervals.
  • 🔧 Changed pinned-card assertions to expect Current and the persistent pin glyph.
  • ✨ Added tagPinGated = true to the pinned-container fixture.
  • 🗑️ Removed the outdated update-insight-kind badge assertion.

…#566

The display-honesty batch changed two surfaces these specs asserted:

- #406: the one-clock maturity panel collapsed the countdown into a
  single '{countdown} · unlocks {date}' line, replacing 'Lifts at'.
- #498: insight-only cards read 'Current' (pinned left the Update
  column) and the insight-kind badge was retired; pinned-ness is the
  persistent pin glyph on the Tag cell, asserted in both table and
  cards. Fixture now sets tagPinGated, the backend gate verdict the
  glyph keys on.

Verified locally: 4 passed against the QA env.
@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
drydock-website Ready Ready Preview, Comment Jul 21, 2026 2:17pm
drydockdemo-website Ready Ready Preview, Comment Jul 21, 2026 2:17pm

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e77494a7-7e83-4f6b-8525-bb5cf76af00a

📥 Commits

Reviewing files that changed from the base of the PR and between bfddb0b and 460fb91.

📒 Files selected for processing (1)
  • e2e/playwright/v16-modes-pins.spec.ts

📝 Walkthrough

Walkthrough

Updated Playwright test #406 to assert stabilization unlock messages for six and five minutes after clock advancement. Updated test #498 to enable pin gating and verify the pinned glyph and Current card update state in both container and Cards views.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/v1.6-e2e-display-honesty

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@scttbnsn

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@scttbnsn

Copy link
Copy Markdown
Contributor Author

Superseded by #574, which includes this PR’s exact E2E fix commit (460fb91a) plus the complete v1.6 review remediation and release hardening. Keeping the full integration on one reviewed path avoids splitting the candidate tree.

@scttbnsn scttbnsn closed this Jul 21, 2026
scttbnsn added a commit that referenced this pull request Jul 21, 2026
Closes every repository-actionable finding from the comprehensive v1.6 review, incorporates the superseded E2E correction from #573, and includes all follow-up review fixes and evidence hardening.
@scttbnsn
scttbnsn deleted the fix/v1.6-e2e-display-honesty branch July 24, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant