✅ test(e2e): align pinned-display and maturity-clock expectations with #566#573
✅ test(e2e): align pinned-display and maturity-clock expectations with #566#573scttbnsn wants to merge 1 commit into
Conversation
…#566 The display-honesty batch changed two surfaces these specs asserted: - #406: the one-clock maturity panel collapsed the countdown into a single '{countdown} · unlocks {date}' line, replacing 'Lifts at'. - #498: insight-only cards read 'Current' (pinned left the Update column) and the insight-kind badge was retired; pinned-ness is the persistent pin glyph on the Tag cell, asserted in both table and cards. Fixture now sets tagPinGated, the backend gate verdict the glyph keys on. Verified locally: 4 passed against the QA env.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated Playwright test 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Superseded by #574, which includes this PR’s exact E2E fix commit ( |
Closes every repository-actionable finding from the comprehensive v1.6 review, incorporates the superseded E2E correction from #573, and includes all follow-up review fixes and evidence hardening.
The 🎭 E2E: Playwright job on release PR #572 caught two specs still asserting pre-#566 display behavior. Both are intentional changes from the display-honesty batch, not regressions:
{countdown} · unlocks {date}line, so theLifts atregexes never match. Updated tounlocks.Currentplus thecontainer-tag-pinned-glyphin both the table row and the card, and the fixture setstagPinGated(the backend gate verdict the glyph keys on).Verified locally against the QA env (drydock:dev, :3333): all 4 tests in the spec pass.
Unblocks #572.
Changelog
unlockswording with updated minute intervals.Currentand the persistent pin glyph.tagPinGated = trueto the pinned-container fixture.