Skip to content

✅ test(api): assert the welcome-version sentinel literally #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scttbnsn merged 1 commit into from
Jul 17, 2026
Merged

✅ test(api): assert the welcome-version sentinel literally #555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/api/portwing-ws.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,7 @@ function buildHello(

test('reports the canonical configuration version in the welcome frame', async () => {
clearNonceCacheForTesting();
vi.mocked(getVersion).mockClear();

const { privateKey, pubkeyBase64, keyId } = generateKeyPair();
const ts = Math.floor(Date.now() / 1000);
Expand Down Expand Up @@ -354,7 +355,10 @@ test('reports the canonical configuration version in the welcome frame', async (
const welcome = JSON.parse(ws.sentMessages[0]) as {
data: { config: { drydockVersion: string } };
};
expect(welcome.data.config.drydockVersion).toBe(getVersion());
// Assert the literal sentinel, not getVersion()'s return — comparing against
// the same mock production calls would pass even if the frame hard-coded it.
expect(welcome.data.config.drydockVersion).toBe('9.9.9-test');
expect(getVersion).toHaveBeenCalled();
});

describe('PORTWING_WS_ROUTE_PATTERN', () => {
Expand Down