fix: drop redundant null check in 503 burst-throttle handler#1
Merged
Conversation
$response is guaranteed non-null inside the `if ($statusCode === 503)` branch — $statusCode was derived from $response->getStatusCode() above, so a non-zero status implies the response exists. PHPStan 2.x flags the ternary as always-true (level 5). No behavior change.
Brentjes
added a commit
that referenced
this pull request
Apr 21, 2026
$response is guaranteed non-null inside the `if ($statusCode === 503)` branch — $statusCode was derived from $response->getStatusCode() above, so a non-zero status implies the response exists. PHPStan 2.x flags the ternary as always-true (level 5). No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ternary.alwaysTrueerror atTransport/JsonRpcClient.php:287if ($statusCode === 503)branch,$responseis already proven non-null ($statusCodewas derived from it above, so any non-zero value implies a response exists)Context
Static-analysis CI has been failing on
mainsince PHPStan 2.x tightened impurity inference. This is the only outstanding error.Test plan
vendor/bin/phpstan analyse— 0 errorsvendor/bin/phpunit— 70/70 passing, 305 assertionsvendor/bin/php-cs-fixer fix --dry-run— clean