Feature/526 average resample - #563
Conversation
Fixes #526 Entire-Checkpoint: 893a1de325b5
Entire-Checkpoint: f69e38210bb1
Entire-Checkpoint: 7536f551d548
A setting nested at the wrong level (e.g. "resampling" placed next to "main" instead of inside it) was silently ignored. Emit a startup warning for any top-level config section not consumed by the backend so such misconfigurations surface instead of failing silently. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Entire-Checkpoint: 69d1b85c8db3
The backend resample config changed from {trigger, resolutions[]} to a
policy/targetPoints model, but several components still spread
resampleConfig.resolutions, throwing "resolutions is not iterable" and
breaking the job list render. Default the initial resolution to null (the
backend resolves it from the configured policy; zoom overrides it) and
drop the now-obsolete resolution selector and admin display fields.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: 27516ce259fd
Bump gqlgen, aws-sdk-go-v2, go-oidc, go-sqlite3, gqlparser, go-openapi, golang.org/x/* and other transitive dependencies to their latest patch and minor releases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Entire-Checkpoint: 964ca6774882
spacehamster87
left a comment
spacehamster87
left a comment
There was a problem hiding this comment.
Sieht im Großteil gut aus, allerdings 2 Dinge:
- Die angepasste Resample-On-Zoom Logik sollte getestet werden vorher
- Die neuen Resample-Optionen müssten von AdminSettings nach UserSettings verschoben werden.
Siehe auch Kommentare.
| <p>Triggered at {resampleConfig.trigger} datapoints.</p> | ||
| <p>Configured resolutions: {resampleConfig.resolutions}</p> | ||
| <p>Resampling is enabled.</p> | ||
| <p>Target data points per plot: {resampleConfig.targetPoints}</p> |
There was a problem hiding this comment.
Hier sollte wahrscheinlich sowas wie "per unique data set" angefügt werden. So wie es jetzt formuliert ist, könnte man fälschlicherweise auf die Gesamtdaten der Plots schließen.
There was a problem hiding this comment.
Kontext: Die PlotRenderOptions sind per Definition keine Admin-Settings, i.e. nicht Admin-exklusiv, sondern für jeden User persönlich setzbar.
Entsprechend sollte die gesamte Update-Logik, und die Komponente selber, die hier für die neuen Resambling Optionen gesetzt wird, nach
web/frontend/src/config/UserSettings.svelte
umgezogen werden.
| timestep := int64(0) | ||
| for i := 0; i < len(v_.Series); i += 1 { | ||
| v_.Series[i].Data, timestep, err = resampler.LargestTriangleThreeBucket(v_.Series[i].Data, int64(v_.Timestep), int64(resolution)) | ||
| v_.Series[i].Data, timestep, err = resampleFn(v_.Series[i].Data, int64(v_.Timestep), int64(resolution)) |
There was a problem hiding this comment.
Interessehalber: Wo kommen die resampleFns her? Habe sie im Diff nicht entdecken können.
There was a problem hiding this comment.
resampleFn, rfErr := resampler.GetResampler(resampleAlgo)
invoked via cc-lib
https://github.com/ClusterCockpit/cc-lib/blob/main/resampler/resampler.go
3 participants
No description provided.