Fix possible double free - #16
Closed
peter15914 wants to merge 1 commit into
Closed
Conversation
entry_list is freed with ssh_list_free(). If list_error is true, it is freed again with ssh_knownhosts_entries_free(), causing double free.
peter15914
marked this pull request as ready for review
September 9, 2026 19:31
Member
|
@peter15914 Please send the fix to the upstream repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
entry_list is freed with ssh_list_free().
If list_error is true, it is freed again with ssh_knownhosts_entries_free(), causing double free.
Context:
list_error is true only if ssh_list_append() returns an error, this occurs when malloc() fails and returns NULL in ssh_iterator_new().
Found with Svace static analyzer.