Skip to content

[client-v2, jdbc-v2] Lazy String instantiation, Read bytes to buffer first #2813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chernser wants to merge 5 commits into
base: main
Choose a base branch
from

Made read String as String by default. Option is to read as BinaryStr…

8724b94
Select commit
Loading
Failed to load commit list.
Draft

[client-v2, jdbc-v2] Lazy String instantiation, Read bytes to buffer first #2813

Made read String as String by default. Option is to read as BinaryStr…
8724b94
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 9, 2026 in 1m 1s

Quality Gate failed

Failed conditions
61.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 1144 in client-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/BinaryStreamReader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to use the more specialised Functional Interface 'IntFunction<ByteBuffer>' 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ1znqHzfrTUmNjb20JI&open=AZ1znqHzfrTUmNjb20JI&pullRequest=2813

Check warning on line 4 in client-v2/src/main/java/com/clickhouse/client/api/ClientConfigProperties.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'com.clickhouse.client.api.data_formats.internal.BinaryString'. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ1zt1tZ_4yywg-9BRWz&open=AZ1zt1tZ_4yywg-9BRWz&pullRequest=2813

Check warning on line 195 in client-v2/src/test/java/com/clickhouse/client/api/data_formats/internal/BinaryStreamReaderTests.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ1znqGofrTUmNjb20JH&open=AZ1znqGofrTUmNjb20JH&pullRequest=2813

Check warning on line 41 in client-v2/src/main/java/com/clickhouse/client/api/internal/DataTypeConverter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "valueConverters" private field. 

See more on https://sonarcloud.io/project/issues?id=ClickHouse_clickhouse-java&issues=AZ1FwnR5MypVGK4GgbNB&open=AZ1FwnR5MypVGK4GgbNB&pullRequest=2813
View more details on SonarQubeCloud