补齐 operational tunable package 默认 #392 ⟦AI:AUTO-LOOP⟧#393
Merged
loning merged 3 commits intoMay 31, 2026
Merged
Conversation
Trigger source: #392 fresh-host package default 补漏。 Action type: 完成已 consensus 的 #388 scope，补齐 operational tunable package ship 默认并加 fresh-host 防漏守卫。 Equivalence: operational-tunable-package-defaults。 Later reuse: fresh host 可从 share/fkst/tunables 读取 operational 默认；conformance 从源码读取点核对 package 默认。 Failure owner: #388/#392 operational tunable defaults。 关联 #392。 ⟦AI:FKST⟧
Contributor
Author
🤖 quality review 通过TL;DR
详细说明我已按要求先刷新 质量角度没有发现需要 comment 或 reject 的问题。 📎 完整 codex 原始输出---
pr: 393
role: quality
verdict: approve
---
## Verdict
approve: 本 PR 变更集中，命名和结构清楚，没有引入明显死代码、误导性注释、单实现过度抽象或无关 cleanup。
## Evidence
- 已按 fresh PR HEAD 验证 tree 中存在本次引用文件：`conformance/operational_tunable_defaults.sh`、`scripts/release_test.sh`、`share/fkst/tunables/archive_prefix.txt`、`share/fkst/tunables/evolve_approach_converge_seconds_budget.txt`。
- `conformance/operational_tunable_defaults.sh:49` 的 `check_package_files` 仍只负责 package tunable 文件存在性与 host-only tunable 排除检查；新增 `operational_tunable_read_paths` 名称表达清楚，函数约 21 行，未增加复杂控制流。
- `conformance/operational_tunable_defaults.sh:67` 从源码中派生 operational tunable 路径，排除测试与 host-policy tunable 的逻辑集中在一个函数内；未出现三处以上重复片段需要抽取，也未新增 filler comment 或历史叙述注释。
- `scripts/release_test.sh:163` 只同步 fixture 默认值从 `900` 到 `1800`，属于相关测试 fixture 更新，不是无关 drive-by change。
- 验证已通过：`bash conformance/operational_tunable_defaults.sh` 和 `bash scripts/release_test.sh`。
REVIEW_DONE:393:quality:approve⟦AI:AUTO-LOOP⟧ |
Contributor
Author
🤖 tests reviewer：缺少 conformance 扫描器自测 fixture，建议先挡下TL;DR
详细说明我按 prompt 先强制 fresh fetch，并只读 问题不是现有仓库跑不过。相反，我在 fresh PR HEAD 的 detached 临时 worktree 里跑了 📎 完整 codex 原始输出pr: 393
|
Contributor
Author
🤖 architect review approve: Tier II 授权与 fresh-host guard 均通过TL;DR
详细说明我按 prompt 先强制 fetch 了 PR ref，再用最新 tree 与 我也跑了 diff anti-pattern scan，没有发现 actor/serializer/sleep/disabled-test/legacy shim/round-stage source marker 类问题；在 PR worktree 上 📎 完整 codex 原始输出---
pr: 393
role: architect
verdict: approve
---
## Verdict
Approve from the architecture compliance angle; the PR touches a Tier II conformance guard, but the fresh PR HEAD has public #388 deep-consensus authorization for this gate shape and the diff does not introduce a new CLAUDE/AGENTS violation.
## Evidence
- Fresh-state completed first: fetched `origin/dev-rc-20260531-ship-missing-tunable-default_from_auto-refact-dev`, listed the PR tree, and read current PR HEAD files via `git show origin/dev-rc-20260531-ship-missing-tunable-default_from_auto-refact-dev:<file>`.
- Changed files verified on PR HEAD: `conformance/operational_tunable_defaults.sh`, `scripts/release_test.sh`, `share/fkst/tunables/archive_prefix.txt`, and `share/fkst/tunables/evolve_approach_converge_seconds_budget.txt` all exist in the refreshed tree.
- Tier II touch checked: `conformance/operational_tunable_defaults.sh:49` introduces the package-file guard and `conformance/operational_tunable_defaults.sh:67` derives operational tunable read paths from source references. CLAUDE.md requires Tier II `SPEC.md + conformance/*.sh` changes to have deep consensus; #388 has public R3 meta-judge consensus at https://github.com/ChronoAIProject/fkst/issues/388#issuecomment-4585958951 explicitly authorizing `conformance/operational_tunable_defaults.sh` as a new/modified operational-default gate.
- Host-policy fail-closed boundary is preserved: `conformance/operational_tunable_defaults.sh:60` through `conformance/operational_tunable_defaults.sh:64` rejects package-shipped `project_rules`, `protected_layer_paths`, `integration_branch`, `host_verify_commands`, and `accepted_ai_sentinels`; `conformance/operational_tunable_defaults.sh:124` through `conformance/operational_tunable_defaults.sh:140` checks missing host `integration_branch` fails before success with a host file.
- Host-configurable substrate facts are not newly hardcoded as fkst-only facts: `share/fkst/fkst/branch_namespace.lua:53` through `share/fkst/fkst/branch_namespace.lua:58` still resolves candidate/archive prefixes through env or tunable-backed configuration, and PR #393 only adds package defaults `archive_prefix=dev-archive-` and `evolve_approach_converge_seconds_budget=1800`.
- Scope honesty holds for the declared #392 follow-up: PR body says it fills missing operational tunable package defaults and adds the fresh-host guard; the diff is limited to that conformance/release/default-file surface.
- Known anti-pattern scan over the diff found no `actor.HandleEventAsync(`, `SubscribeAsync<EventEnvelope>`, JSON serializer state payloads, production `sleep/delay`, sync-over-async marker, raw `HttpClient`, disabled `[Skip]` tests, legacy/deprecated shim markers, or source round/stage labels.
- Verification run in the PR worktree passed: `bash conformance/operational_tunable_defaults.sh` and `bash conformance/run_all.sh`.
## What would change your verdict (only if comment or reject)
N/A
REVIEW_DONE:393:architect:approve⟦AI:AUTO-LOOP⟧ |
补齐 conformance/operational_tunable_defaults.sh --self-test，覆盖缺失包默认值失败与完整默认值通过。 让 conformance/run_all.sh 在 operational tunable defaults 序列中执行该自测，并补齐 run_all 自测 fixture 的包默认 tunables。 验证: cargo test --workspace -- --test-threads=1; bash conformance/operational_tunable_defaults.sh --self-test; bash conformance/run_all.sh。 ⟦AI:FKST⟧
Contributor
Author
🤖 tests reviewer: reject，conformance self-test 没锁住新增扫描路径TL;DR
详细说明
我在 fresh PR HEAD 上做了最小变异验证：删除 📎 完整 codex 原始输出---
pr: 393
role: tests
verdict: reject
---
## Verdict
Reject: the PR expands the operational tunable conformance scan, but the self-test only proves one overlapping missing-default case and does not lock each newly scanned production path.
## Evidence
- `conformance/operational_tunable_defaults.sh:73-74` now discovers tunable reads with `git grep` across `share/fkst`, `scripts/fkst-config.sh`, `crates/fkst-framework/src`, `crates/fkst-supervisor/src`, and `crates/fkst-common/src`. Fresh PR HEAD verification: `git show origin/dev-rc-20260531-ship-missing-tunable-default_from_auto-refact-dev:conformance/operational_tunable_defaults.sh` shows `git grep ... -- share/fkst scripts/fkst-config.sh crates/fkst-framework/src crates/fkst-supervisor/src crates/fkst-common/src`.
- `conformance/operational_tunable_defaults.sh:159-168` creates allowed fixture references in `share/fkst/departments/sample/main.lua` and `crates/fkst-framework/src/lib.rs`, but `conformance/operational_tunable_defaults.sh:195` creates the only violating fixture by deleting `share/fkst/tunables/queue_capacity.txt`. That missing default is still referenced by `scripts/fkst-config.sh`, so the bad fixture does not prove the `share/fkst` or `crates/fkst-framework/src` scan entries are enforced.
- Mutation check on fresh PR HEAD confirms the gap: after deleting `share/fkst` and `crates/fkst-framework/src` from `operational_tunable_read_paths`, `bash conformance/operational_tunable_defaults.sh --self-test` still returned `status=0` with `operational tunable defaults self-test ok`. This means a real regression that drops newly scanned production paths would not be caught by the detector self-test.
- Dead-test wiring is present: `conformance/run_all.sh:147-151` calls both `bash conformance/operational_tunable_defaults.sh --self-test` and `bash conformance/operational_tunable_defaults.sh`.
## What would change your verdict
Add self-test fixtures that isolate each scanned production path, with at least one allowed and one violating case per path introduced or covered by the dynamic scan. For example, delete a tunable referenced only by the fixture's `share/fkst` file and assert failure, delete one referenced only by `crates/fkst-framework/src` and assert failure, and keep the current complete fixture as the allowed case.
REVIEW_DONE:393:tests:reject⟦AI:AUTO-LOOP⟧ |
触发来源: tests r2 reject POSTED:tests:393 要求锁住 operational tunable 新增扫描路径。 行为类型: 扩展 conformance/operational_tunable_defaults.sh self-test fixture。 等价语义: 每个 production scan root 都有独立 tunable 引用和缺失默认值反例。 可复用性: 后续新增扫描 root 可沿用 expect_scanned_path 与 missing-default fixture 模式。 失败痕迹归属: conformance self-test coverage gap; 验证 cargo test --workspace -- --test-threads=1, bash conformance/run_all.sh, bash conformance/operational_tunable_defaults.sh --self-test。
Contributor
Author
🤖 tests reviewer approveTL;DR
详细说明我按要求先强制刷新并读取了 测试角度看，新增自测不是只跑 happy path：fixture 覆盖 📎 完整 codex 原始输出---
pr: 393
role: tests
verdict: approve
---
## Verdict
approve: fresh PR HEAD 的测试覆盖和门禁接线足够覆盖本次 tunable default guard 变更。
## Evidence
- `conformance/operational_tunable_defaults.sh:67` 的 `operational_tunable_read_paths` 新增扫描 `share/fkst`、`scripts/fkst-config.sh`、`crates/fkst-framework/src`、`crates/fkst-supervisor/src`、`crates/fkst-common/src`，并排除 test/conformance 路径；`conformance/operational_tunable_defaults.sh:148` 的自测 fixture 为每个新增扫描根写入一个 tunable 引用，`conformance/operational_tunable_defaults.sh:241` 先验证完整 fixture 通过，再逐个删除默认文件并断言 guard 失败，覆盖了新增扫描范围的 allowed 与 violating fixture。
- `conformance/run_all.sh:147` 在标准 `check_operational_tunable_defaults` gate 中显式运行 `bash conformance/operational_tunable_defaults.sh --self-test` 和主 guard；`conformance/run_all.sh:388` 也在 `run_all.sh --self-test` 中显式调用该自测，`.github/workflows/ci.yml:17` 通过 `bash conformance/run_all.sh` 跑标准入口。因此新增自测不是 dead test。
- Fresh PR HEAD 上已验证实际 tree 包含 `conformance/operational_tunable_defaults.sh`、`conformance/run_all.sh`、`scripts/release_test.sh`、`share/fkst/tunables/archive_prefix.txt`、`share/fkst/tunables/evolve_approach_converge_seconds_budget.txt`。我还运行了 `bash conformance/operational_tunable_defaults.sh --self-test`、`bash conformance/operational_tunable_defaults.sh`、`bash conformance/run_all.sh --self-test`，均通过。
- Diff grep 未发现新增 `sleep`/`delay` pacing、`[Skip]`、`Manual` trait、`Assert.True(true)` 或明显断言放松。
REVIEW_DONE:393:tests:approve⟦AI:AUTO-LOOP⟧ |
loning
deleted the
dev-rc-20260531-ship-missing-tunable-default_from_auto-refact-dev
branch
loning
restored the
dev-rc-20260531-ship-missing-tunable-default_from_auto-refact-dev
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
验证
关联 #392
⟦AI:AUTO-LOOP⟧