Skip to content

Decode the response as untyped JSON - #66

Merged
qezz merged 1 commit into
mainfrom
try-make-work-polygon
Jun 23, 2026
Merged

Decode the response as untyped JSON#66
qezz merged 1 commit into
mainfrom
try-make-work-polygon

Conversation

@qezz

@qezz qezz commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

The cometbftClient.Status() tries to decode the response with some hardcoded tags, which don't include the one used by Polygon Heimdall (v2), and therefore making Blazar fail on the post upgrade check:

Post-upgrade check failed

error: post upgrade upgrade-block-signed check failed: Could not get
node status: error in json rpc client, with http response metadata:
(Status: 200 OK, Protocol HTTP/1.1). error unmarshalling result:
unknown type "cometbft/PubKeySecp256k1eth"

This patch avoids matching the type, as we don't really need it.

@qezz
qezz force-pushed the try-make-work-polygon branch from 3a13c04 to 1156a79 Compare June 22, 2026 15:12
@qezz
qezz changed the base branch from main to fix-block-time-avg June 22, 2026 15:21
@qezz

qezz commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

this works, but stacked on top of #67, as i want to merge that patch (to be v1.8.3) and then merge this (to be v1.9.0)

upd: #67 is merged, v1.8.3 is released

@qezz
qezz marked this pull request as ready for review June 22, 2026 15:22
@qezz
qezz requested a review from a team June 22, 2026 15:22
@qezz
qezz force-pushed the try-make-work-polygon branch from 1156a79 to eeeb3f1 Compare June 22, 2026 15:41
@qezz
qezz changed the base branch from fix-block-time-avg to main June 22, 2026 15:42
The `cometbftClient.Status()` tries to decode the response with some
hardcoded tags, which don't include the one used by Polygon Heimdall
(v2), and therefore making Blazar fail on the post upgrade check:

```
Post-upgrade check failed

error: post upgrade upgrade-block-signed check failed: Could not get
node status: error in json rpc client, with http response metadata:
(Status: 200 OK, Protocol HTTP/1.1). error unmarshalling result:
unknown type "cometbft/PubKeySecp256k1eth"
```

This patch avoids matching the type, as we don't really need it.
@qezz
qezz force-pushed the try-make-work-polygon branch from eeeb3f1 to 787088c Compare June 22, 2026 15:46
@qezz
qezz merged commit 145f9ac into main Jun 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants