Update to go 1.24, update testcontainers-go - #63
Conversation
Old testcontainers are broken with Docker Engine v29. Bumping it to the most recent v0.40.0
|
have not yet checked any breaking changes in testcontainers (which apparently has plenty of) |
| golang.org/x/sync v0.8.0 | ||
| golang.org/x/sys v0.24.0 | ||
| github.com/stretchr/testify v1.11.0 | ||
| github.com/testcontainers/testcontainers-go v0.40.0 |
There was a problem hiding this comment.
we update from 0.27 to 0.40
upgrades with listed breaking changes
- .28 - https://github.com/testcontainers/testcontainers-go/releases/tag/v0.28.0
- .31 - https://github.com/testcontainers/testcontainers-go/releases/tag/v0.31.0
- .33 - https://github.com/testcontainers/testcontainers-go/releases/tag/v0.33.0
- .35 - https://github.com/testcontainers/testcontainers-go/releases/tag/v0.35.0
- .36 - https://github.com/testcontainers/testcontainers-go/releases/tag/v0.36.0
- .38 - https://github.com/testcontainers/testcontainers-go/releases/tag/v0.38.0
- .40 - https://github.com/testcontainers/testcontainers-go/releases/tag/v0.40.0
There was a problem hiding this comment.
0.33
⚠️ Breaking Changesfix!: docker authentication setup (https://github.com/testcontainers/testcontainers-go/pull/2727) @stevenhIf you are building Docker images with the FromDockerfile struct in the GenericContainerRequest, please consider that the ContextArchive field in that struct has changed from io.Reader to io.ReadSeeker. This is needed because we want to be able to rewind to do multiple passes when reading all the images that are present in a Dockerfile.
We do use FromDockerfile, but we don't set ContextArchive, so I think we are fine
There was a problem hiding this comment.
0.36 https://github.com/testcontainers/testcontainers-go/releases/tag/v0.36.0 comes with a docker library update, which is already included in this PR
other changes don't seem to affect us
|
Also checked the go 1.22 to 1.24 (https://go.dev/doc/go1.23, https://go.dev/doc/go1.24) and it seems to be chill |
|
Hm, I probably need to cut a new release with this one |
|
A tag is enough for golang. |
Old testcontainers are broken with Docker Engine v29. Bumping it to the most recent v0.40.0