add a created_at field to the schema - #60
Conversation
5e7b01d to
6e3838b
Compare
|
as for me lgtm (apart the linter notice about unused field) |
|
i'll follow up with a pr for UI changes |
6ce13b1 to
04e3089
Compare
| t = v | ||
| case string: | ||
| var err error | ||
| t, err = time.Parse("2006-01-02 15:04:05.999999-07:00", v) |
There was a problem hiding this comment.
this timestamp is slightly different to
RFC3339Nano = "2006-01-02T15:04:05.999999999Z07:00"
is that intentional? (T -> , Z -> -, 999999999 -> 999999)
does it make sense to store the timestamp as a string, vs a timestamp (numeric 64b value)?
There was a problem hiding this comment.
is that intentional? (T -> , Z -> -, 999999999 -> 999999)
afaict this is the protobuf's timestamp format, although i might be wrong on this one as im not super familiar with protobuf
does it make sense to store the timestamp as a string, vs a timestamp (numeric 64b value)?
wdym?
There was a problem hiding this comment.
i meant that instead of having a date type we could store an uint64 but it's 0/5 for me
There was a problem hiding this comment.
you dont mean storage, but the protobuf schema? because in postgres we store timestamps
There was a problem hiding this comment.
ah wtf github trolling me
3 participants
Adds a
CreatedAtfield to the proto and database schema.To work with using the generated proto type as the database model, custom serializers are used
For database/local providers (both upgrades and versions), the field is obvious.
For the chain upgrade provider, the
SubmitTimeis used as the created at field for upgrades.Closes #12