feat(log): move processing info log to debug level, add builder log#43
Draft
youen wants to merge 2 commits into
Draft
feat(log): move processing info log to debug level, add builder log#43youen wants to merge 2 commits into
youen wants to merge 2 commits into
Conversation
youen
commented
Jun 14, 2021
Collaborator
adrienaury
requested changes
Jun 14, 2021
Member
There was a problem hiding this comment.
- This demo need to be updated https://github.com/CGI-FR/PIMO/tree/main/demo/demo9
- CHANGELOG
youen
commented
Jun 15, 2021
| // MaskEngine is a masking algorithm | ||
| type MaskEngine interface { | ||
| Mask(Entry, ...Dictionary) (Entry, error) | ||
| Name() string |
Collaborator
Author
There was a problem hiding this comment.
Maybe Name is not the good name... String()
Member
There was a problem hiding this comment.
Yes, signature String() string if you want to implement the fmt.Stringer interface (and then get compatibility with all method from fmt package)
Be careful to not use fmt.Printf("%v", mask) inside String() string because you will have an infinite loop
adrienaury
approved these changes
Jun 16, 2021
Member
|
Maybe instead of
use
Because there is a mask named Add and it can be confusing ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.