Repository navigation
fix: scope XP award publication to the authenticated learner - #1054
Open
AzahasTech wants to merge 5 commits into
Open
AzahasTech wants to merge 5 commits into
AzahasTech wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR enforces learner scoping on XP award publication so that a learner can only publish award events for themselves. The controller now derives the acting learner from the authenticated request context, and the service rejects any attempt to publish an award event on behalf of a different learner.
Related Issue
Changes
🔒 Learner-Scoped XP Publication
[MODIFY]
BackendAcademy/src/gamification/xp.controller.ts[MODIFY]
BackendAcademy/src/gamification/xp.service.ts[MODIFY]
BackendAcademy/src/gamification/xp.service.spec.tsVerification Results
Closes #999