Skip to content

Fix PDF compaction replay and work-pane controls - #714

Merged
lucasnewman merged 2 commits into
mainfrom
pc/fix-pdf-compaction-and-pane-controls
Oct 19, 2026
Merged

lucasnewman merged 2 commits into
mainfrom
pc/fix-pdf-compaction-and-pane-controls

Conversation

@Blaizzy

@Blaizzy Blaizzy commented Oct 14, 2026 •

Copy link
Copy Markdown
Owner

Refreshing or trimming PDF excerpts changed messages already covered by a saved summary, invalidating compaction state and replaying the full transcript. Keep stable attachment references in conversation history, send fresh excerpts as request context, and fit documents against the saved summary plus the remaining messages.

The window-drag overlay also intercepted clicks on the work-pane header. Make it yield hit testing while the pane is visible, observing visibility changes immediately, so the add, expand, and menu controls receive clicks.

Validation

  • Debug macOS build succeeded.
  • 50 focused tests passed; one optional live-model compaction test was skipped.
  • Regression coverage checks changed, trimmed, and omitted PDF excerpts preserve the saved summary; real message edits and attachment replacement invalidate it.
  • Additional coverage checks token counting uses compacted history and pane controls receive clicks across visibility changes.

@Blaizzy Blaizzy changed the title Fix PDF compaction replay and work-pane controls Fix chat compaction and pane controls; support original file uploads Oct 14, 2026
@Blaizzy
Blaizzy force-pushed the pc/fix-pdf-compaction-and-pane-controls branch from 1d31cdf to 9e30e5c Compare October 14, 2026 22:46
@Blaizzy Blaizzy changed the title Fix chat compaction and pane controls; support original file uploads Fix PDF compaction replay and work-pane controls Oct 14, 2026
@Blaizzy
Blaizzy requested a review from lucasnewman October 19, 2026 15:35
Preserve unknown-tool recovery alongside stable attachment references and update prompt API callers. Add regression coverage for saved PDF compaction after tool recovery.
@lucasnewman
lucasnewman force-pushed the pc/fix-pdf-compaction-and-pane-controls branch from 84dc2d5 to bfaf9ce Compare October 19, 2026 16:56
@lucasnewman
lucasnewman merged commit 17d3db0 into main Oct 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants