[codex] Lock StackingDAO minimum liquidity#20
Open
caydyan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens StackingDAO pool initialization by permanently locking a small LP supply at pair creation.
minimum-liquidityconstant ofu1000LP unitsinitial-lp-supply - minimum-liquidityto the initial LP ownerminimum-liquidityto thestableswap-stackingDAOcontract principal so it cannot be user-withdrawnThe pool's
total-sharesremains the full initial LP supply, so existing proportional accounting keeps using the full supply denominator while the creator cannot withdraw the pool to zero.Audit context
This addresses the published ClankOS / AIBTC Bitflow StackingDAO audit finding about missing minimum-liquidity locking during initialization. Without a lock, the initial LP owner can burn all minted LP and leave zero pool balances / zero shares.
If accepted for the AIBTC fix-PR bounty, BTC payout address:
bc1qev5ant33v5y89qqjvcf4mh9hlax5svqf5xd7gcValidation
git diff --checkclarinet checkclarinet consolescenario:create-pairmintsu19999999999000LP to the creator andu1000LP to.stableswap-stackingDAOu9999999999500of each asset{ balance-x: u500, balance-y: u500, total-shares: u1000 }u500/u500initial liquidity returns(err "err-initial-liquidity-too-low")