[codex] Fix StackingDAO admin swap fees#16
Open
caydyan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the StackingDAO stableswap fee selection for admin vs non-admin swaps.
swap-x-for-yandswap-y-for-xboth documented that admins should use the admin swap fee schedule, but the branch was inverted: admins were charged the regular buy/sell fees while non-admin users received the admin fee schedule. With the defaultadmin-swap-feesset to zero, this meant ordinary users could swap without the intended normal fees.This updates both swap paths so:
admin-swap-feesbuy-fees/sell-feesThis corresponds to the published stSTX/STX stableswap audit finding about the inverted fee branch.
Validation
clarinet checkpasses (12 contracts checked; existing repository warnings remain)git diff --checkswap-x-for-ysmall amount:(ok u10000)with default zero admin feeswap-x-for-ysmall amount:(ok u9995)with 3/1/1 normal feesswap-y-for-xsmall amount:(ok u10000)with default zero admin feeswap-y-for-xsmall amount:(ok u9995)with 3/1/1 normal feesNote: this repo's test files use the older Clarinet/Deno test style and this checkout does not include a
package.json; current Clarinet 3 providesclarinet checkbut not the oldclarinet testsubcommand.