Repository navigation
fix: copy_group fallback uses zarr.from_array instead of deprecated pydantic-zarr IO - #291
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #287, closes #288.
pydantic-zarr 0.11.0 deprecated
ArraySpec.from_zarr/to_zarr(removal in 0.12). ngio called both in the zarr-python fallback ofcopy_group, and the test suite turns warnings into errors, so the weekly pip CI went red on both jobs (80 tests each, all this one warning).zarr.from_array(..., write_data=False). ngio no longer imports pydantic-zarr, which was never a declared dependency.from_arrayon zarr 3.1.6 does not carry over the fill value or attributes, so both are passed explicitly.test_copy_group_fallback_keeps_array_metadata: copied metadata and data equal the source for zarr v2 and v3 (fill value, attributes, key encoding, no compressor, 0-d, strings, sharding with dimension names).[Unreleased].Checked locally: full suite passes in a fresh pip environment with pydantic-zarr 0.11.0 and zarr 3.4.2 (1703 passed, 30 skipped, network tests deselected).
🤖 Generated with Claude Code