Repository navigation
fix: fractal_fsspec_store probes zarr.json so OME-Zarr 0.5 stores open - #290
Merged
Merged
Conversation
#289) Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #289.
fractal_fsspec_storechecked the URL by fetching only the zarr v2 keys (.zgroup,.zarray), so every OME-Zarr 0.5 / zarr v3 store raisedNgioValueError("Store ... can not be read")even when the data was reachable. The probe now trieszarr.jsonfirst.[Unreleased].Not covered: the 401 token errors on a v3 store (no token-protected server in the tests). The handling in
_probe_keydoes not depend on the key.🤖 Generated with Claude Code