Skip to content

🎨 Palette: Add explicit ARIA labels to responsive icon buttons#88

Open
Bhishaj9 wants to merge 1 commit into
mainfrom
fix/aria-labels-for-responsive-buttons-4475337916661591537
Open

🎨 Palette: Add explicit ARIA labels to responsive icon buttons#88
Bhishaj9 wants to merge 1 commit into
mainfrom
fix/aria-labels-for-responsive-buttons-4475337916661591537

Conversation

@Bhishaj9

Copy link
Copy Markdown
Owner

This PR addresses a critical accessibility oversight in the frontend where buttons and links with responsive text (e.g. Deploy or Back to Home) lose their accessible name on smaller viewports because their visible text is hidden via Tailwind classes (e.g. hidden lg:inline).

Furthermore, raw Material Symbols ligatures inside these elements were not masked, meaning screen readers would announce the raw text like "rocket launch" instead of the intended button action.

Changes:

  • Added aria-label attributes to the 'Deploy', 'Copy JSON', 'Download JSON' buttons and the 'Back to Home' link across dashboard.html, glassui.html, and code.html.
  • Added aria-hidden="true" to the inner <span class="material-symbols-outlined"> elements to mask the ligatures from screen readers.
  • Documented this responsive accessibility learning in a new .jules/palette.md journal.

These changes have been visually verified using Playwright screenshots, ensuring no unintended visual shifts, and the existing test suite passes cleanly.


PR created automatically by Jules for task 4475337916661591537 started by @Bhishaj9

…screen readers

This commit ensures that interactive elements (buttons and links) which use Tailwind's `hidden` classes to conceal their text on smaller screens remain accessible by explicitly defining their `aria-label`. It also applies `aria-hidden="true"` to inner material icons to prevent screen readers from announcing raw ligatures (e.g., "rocket launch", "content copy"). These a11y improvements were made across `dashboard.html`, `glassui.html`, and `code.html`. Additionally, it establishes a `.jules/palette.md` journal detailing this responsive accessibility pattern.

Co-authored-by: Bhishaj9 <144550237+Bhishaj9@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant