fix: Replace SplObjectStorage PHP 8.5 deprecated methods - #56
Merged
Merged
Conversation
antten
marked this pull request as ready for review
August 10, 2026 09:10
Benoit382
approved these changes
Aug 10, 2026
Oliboy50
approved these changes
Aug 11, 2026
Oliboy50
left a comment
Oliboy50
left a comment
Member
There was a problem hiding this comment.
even though the docs suggest to switch from attach/detach to offsetSet/offsetUnset, this PR changes seem to be identical (because $throwable cannot be null)
👏
antten
force-pushed
the
fix/replace_splobjectstorage_deprecated_methods
branch
from
August 11, 2026 13:01
cacc782 to
7541e66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Why?
In PHP 8.5, the methods
attach()anddetach()onSplObjectStorageare deprecated. SinceSplObjectStorageimplements theArrayAccessinterface, we can easily replace these methods using array syntax instead.🚀 This PR updates our code to avoid deprecation warnings in PHP 8.5+.