Skip to content

Quickstart Remote SSH Workflow - #55

Merged
Israel Miller (imiller31) merged 3 commits into
mainfrom
ismille/aks-ssh-quickstart
Apr 23, 2026
Merged

Israel Miller (imiller31) merged 3 commits into
mainfrom
ismille/aks-ssh-quickstart

Conversation

@imiller31

@imiller31 Israel Miller (imiller31) commented Apr 20, 2026 •

Copy link
Copy Markdown
Contributor

This pull request adds support for overriding the agent install script download URL via a new --agent-url flag in the manual-bootstrap command. This enables users to specify a custom URL for the agent binary when generating bootstrap scripts, improving flexibility for air-gapped or custom deployments. The change is carefully scoped to only apply to the script variant, and includes robust shell-quoting for safety. Comprehensive tests are added to verify correct behavior and security.

Manual bootstrap enhancements:

  • Added a new --agent-url flag to the manual-bootstrap command, allowing users to override the agent download URL in the generated install script. The flag is only supported for the script variant, with validation to prevent misuse. (cmd/kubectl-unbounded/app/machine_manual_bootstrap.go [1] [2] [3] [4]
  • Modified the script rendering logic to inject the custom agent URL as an exported environment variable (AGENT_URL) in a shell-safe manner when the flag is set. (cmd/kubectl-unbounded/app/machine_manual_bootstrap.go [1] [2] [3]

Testing improvements:

  • Added unit and integration tests to verify that the --agent-url flag works as intended, including proper shell quoting and variant validation. Tests ensure the agent URL is correctly injected or omitted, and that unsafe values are handled securely. (cmd/kubectl-unbounded/app/machine_manual_bootstrap_test.go [1] [2] [3]

Install script validation:

  • Updated tests to ensure the agent install script supports the new AGENT_URL environment variable and uses it as the download source if set. (internal/provision/script_test.go internal/provision/script_test.goR20-R23)

Build configuration:

  • Minor Makefile change to allow overriding the MACHINA_IMAGE variable externally. (Makefile MakefileL21-R21)

@imiller31
Israel Miller (imiller31) marked this pull request as ready for review April 20, 2026 19:15
@imiller31
Israel Miller (imiller31) requested a review from a team April 20, 2026 19:15
@imiller31 Israel Miller (imiller31) changed the title [wip] Quickstart Remote SSH Workflow Quickstart Remote SSH Workflow Apr 23, 2026
@imiller31

Copy link
Copy Markdown
Contributor Author

@imiller31
Israel Miller (imiller31) enabled auto-merge (squash) April 23, 2026 18:07
@imiller31
Israel Miller (imiller31) merged commit f7e1e9f into main Apr 23, 2026
22 checks passed
@imiller31
Israel Miller (imiller31) deleted the ismille/aks-ssh-quickstart branch April 23, 2026 18:28

This branch was previously deployed

1 inactive deployment
azure-ci — 50bf2175 Deployed Apr 23, 2026 by imiller31 via azure-cleanup #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants