Fix diagnostic locations for inherited bicepparam values#20085
Open
polatengin wants to merge 5 commits into
Open
Conversation
…n direct extends path
…ed Bicep parameter file
Contributor
|
Test this change out locally with the following install scripts (Action run 30045701207) VSCode
Azure CLI
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #19982.
Type diagnostics for parameter values inherited from an extended
.bicepparamfile were generated using spans from the parent file, but published against the child file. This caused diagnostics to appear on unrelated text, such as theusingorextendsdeclarations.This change re-anchors diagnostics for inherited parameter values to the child file's
extendspath while preserving their original code, message, and severity.I've added integration tests to improve coverage for different scenarios.
Checklist
Microsoft Reviewers: Open in CodeFlow