Skip to content

Fix apiVersionToFloat crashing on preview API versions with a sub-version #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Allan Oliveira (allan-oliveira) wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix apiVersionToFloat crashing on preview API versions with a sub-version #1511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion azure-devops/azext_devops/dev/team/invoke.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def invoke(area=None, resource=None,


def apiVersionToFloat(apiVersion):
apiVersion = apiVersion.replace('-preview', '')
apiVersion = apiVersion.split('-preview')[0]

return float(apiVersion)

Expand Down
24 changes: 24 additions & 0 deletions azure-devops/azext_devops/tests/latest/team/test_invoke.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# --------------------------------------------------------------------------------------------
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License. See License.txt in the project root for license information.
# --------------------------------------------------------------------------------------------

import unittest

from azext_devops.dev.team.invoke import apiVersionToFloat


class TestApiVersionToFloat(unittest.TestCase):

def test_plain_version(self):
self.assertEqual(apiVersionToFloat('7.1'), 7.1)

def test_preview_version_without_subversion(self):
self.assertEqual(apiVersionToFloat('7.1-preview'), 7.1)

def test_preview_version_with_subversion(self):
# e.g. "7.1-preview.1" - the sub-version suffix used to break float() conversion
self.assertEqual(apiVersionToFloat('7.1-preview.1'), 7.1)

def test_preview_version_with_multi_digit_subversion(self):
self.assertEqual(apiVersionToFloat('5.0-preview.10'), 5.0)