You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
npm run lint -- src/components/Sidebar.tsx src/components/TopHeader.tsx src/components/OverviewCards.tsx could not complete locally because dependencies are not installed and eslint is not available on PATH in this worktree
Hey @nonggde, this is a solid improvement! Moving from a hardcoded dark theme to a proper @custom-variant dark setup with CSS variables is the right approach.
A couple of suggestions:
System preference: Consider respecting prefers-color-scheme on first load. You can add @media (prefers-color-scheme: dark) { :root { ... } } as a default before the user explicitly toggles.
Transition smoothness: Adding a brief transition: background-color 0.2s, color 0.2s on the body or :root makes the theme switch feel smoother rather than an abrupt change.
LocalStorage persistence: Make sure the theme choice is saved to localStorage so it persists across page reloads and sessions.
Looking forward to seeing the full implementation!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.darkcustom variant support inglobals.cssSidebar,TopHeader, andOverviewCardsValidation
git diff --checkrg -n "@custom-variant dark|dark:bg|dark:text|dark:border|dark:placeholder|dark:focus" app/src/app/globals.css app/src/components/Sidebar.tsx app/src/components/TopHeader.tsx app/src/components/OverviewCards.tsxnpm run lint -- src/components/Sidebar.tsx src/components/TopHeader.tsx src/components/OverviewCards.tsxcould not complete locally because dependencies are not installed andeslintis not available on PATH in this worktreeCloses #14