Skip to content

fix: placeholder names that were translated in 10 locales - #9035

Open
Na5co wants to merge 1 commit into
AppFlowy-IO:mainfrom
Na5co:fix-translated-placeholders
Open

Na5co wants to merge 1 commit into
AppFlowy-IO:mainfrom
Na5co:fix-translated-placeholders

Conversation

@Na5co

@Na5co Na5co commented Sep 21, 2026 •

Copy link
Copy Markdown

14 strings in frontend/resources/translations have the placeholder name itself translated, so the app shows {nom} or {Zeit} instead of the value:

  • tooltip.referencePage: {name} became {nom} (ca-ES, fr-CA, fr-FR), {Name} (de-DE), {nombre} (es-VE), {izena} (eu-ES), {nama} (id-ID), {nome} (it-IT), {nazwa} (pl-PL)
  • web.fileBlock.linkedAt and web.fileBlock.uploadedAt (de-DE): {Zeit} → {time}
  • time.minutes.other (fr-FR): {compter} → {count}
  • settings.accountPage.officialVersion (it-IT): {versione} → {version}
  • label.stepX (am-ET): {x} → {X}

Only the tokens change, no wording. Files keep their formatting, one line per string.

Summary by Sourcery

Bug Fixes:

  • Correct translated placeholder names across ten locale files so localized strings interpolate the intended values correctly.

Found by running polygo check over the locale files, then verified each one by hand against the English source.

{name} became {nom}/{nombre}/{nazwa}, {time} became {Zeit}, {count} became
{compter}; the UI shows the braces literally. Tokens only, 14 strings.
@sourcery-ai

sourcery-ai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR makes token-only corrections across 10 locale files, restoring 14 translated placeholders to the canonical names and casing expected by the application while preserving all wording and formatting.

File-Level Changes

Change Details Files
Restore the canonical placeholder tokens in localized translation strings so runtime interpolation receives the expected variable names.
  • Change translated variants of {name} back to {name} in tooltip.referencePage across nine locales.
  • Change {Zeit} to {time} for German file timestamps.
  • Change {compter} to {count} in the French pluralized minutes string.
  • Change {versione} to {version} in the Italian official-version label.
  • Change {x} to {X} in the Amharic step label.
frontend/resources/translations/am-ET.json
frontend/resources/translations/ca-ES.json
frontend/resources/translations/de-DE.json
frontend/resources/translations/es-VE.json
frontend/resources/translations/eu-ES.json
frontend/resources/translations/fr-CA.json
frontend/resources/translations/fr-FR.json
frontend/resources/translations/id-ID.json
frontend/resources/translations/it-IT.json
frontend/resources/translations/pl-PL.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@CLAassistant

CLAassistant commented Sep 21, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@github-actions

Copy link
Copy Markdown

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports level link
Identical pattern 1 warning contribute (via Fink 🐦)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants