libiberty: return a copy of the name when lrealpath has no realpath - #20
Merged
Merged
Conversation
On hosts without realpath, canonicalize_file_name or _WIN32 the function fell off its end, so gcc at -Os compiled it to a bare rts and ld/bfd callers got an undefined pointer back.
MBeijer
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same fix as AmigaPorts/gcc for the binutils copy of libiberty:
lrealpathhas no code path for a host withoutrealpath,canonicalize_file_nameor Win32 and falls off the end of the function, which gcc at-Oscompiles into a barerts. The AmigaOS-hosted ld and bfd callers (ldfile.c,ldmain.c,opncls.c) got an undefined pointer back. Return a copy of the name instead.