vamos: fix test suite regressions from the bebbo sync - #2
Merged
Conversation
Flush and FGets compared fh.obj.fileno() with sys.stdin.fileno(), which raises io.UnsupportedOperation under pytest's captured stdin and on any pseudofile stdin. Guard the comparison.
The preseeded refcount never drops to zero, so natively loaded libraries were never recognized as closed and never expunged, breaking 10 libmgr/libnative unit tests. If closing a library via its load address needs supporting, it should be handled explicitly in close_lib instead.
open_lib required sdl2 for any use of the library, failing even graphics-free calls like CurrentTime when pysdl2 is not installed (as in the CI tox envs). Degrade to headless instead; the rendering paths import sdl2 lazily and fail only when actually used. Guard close_lib against the screen that was never created.
actions/checkout@v3 and setup-python@v4 target the deprecated Node.js 20 runtime and warn on every run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes for test failures introduced by #1 (the full pytest suite is green with these):
fh.obj.fileno()withsys.stdin.fileno(), which raisesio.UnsupportedOperationunder pytest's captured stdin (and any pseudofile stdin). This broke the proc_args and dos_system suites.