add: GNS (.gwei) names support#25
Draft
lucadonnoh wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
UI counterpart of AmbireTech/ambire-common#2522: surfaces GNS (
.gwei) names everywhere ENS and Namoshi names already appear.GnsIcon: new svg component (the GNS pixel-G), theme-aware, same shape asNamoshiIcon.AddressInput:.gweiresolution icon and the "Address / ENS / Namoshi / GNS" placeholder.DomainBadge: GNS badge next to avatars (account rows, address book, signing screens, Benzin).useAddressInput/validation:isValidGwei, "Valid GNS domain", failure and warning messages.useResolveDomain/useReverseLookup:'gwei'in the type unions, reverse-name fallback chain.useAccountsList:.gweinames included in the account fuzzy search.Depends on
AmbireTech/ambire-common#2522 (adds the
gweifields andresolvedAddressTypeunion this code reads). This branch deliberately does not touch the submodule pointer; type-checks will go green once the submodule is bumped past that PR. Marked as draft until then.To try it now: point
src/ambire-commonatlucadonnoh/ambire-common#feature/gwei-names, then type a.gweiname (e.g.donnoh.gwei, live on mainnet with a primary name set, so both directions demo) into Send or Add Contact.Verification
yarn extension:type:check-newwith the common branch checked out in the submodule: "0 new errors found. 159 errors already in baseline."npx eslinton all touched files: nothing on changed lines.