Casimir43/enhancement/657 update coming soon page#662
Conversation
Skoivumaki
left a comment
There was a problem hiding this comment.
Build is failing on tests. Fix or remove tests causing issues.
Removed the invalid assertion. Tests passes now. |
Skoivumaki
left a comment
There was a problem hiding this comment.
The animation looks great 👍
There´s still some odd changes done, that require explanation or discarding:
- You didn't use the
Glasscomponent that was requested, but I think your implementation might have been better/easier. - You removed
GlassfromHeaderDesktop/HeaderMobile, which breaks the component on pages its referred on. (it seems you were planning to use this component and decided not to, but forgot to remove the edits.) - Sometimes you implement fonts incorrectly, not serious but bad for structure. (https://github.com/Alt-Org/Altzone-WebPages/wiki/9.-Css-rules#fonts)
- See comments
There was a problem hiding this comment.
What does editing navbar have to do with issue?
There was a problem hiding this comment.
Accident from my end. Editing Navbar is my other issue im working on. Forgot to switch branches more likely. Or just having both issues open and made the edits accidentally on another window that was suppose to be for the other issue.
The pre-existing glass component does not like following curves(it would just be behind the title not follow along the curve). One way was to make the title so that each letter are seperate and apply the glass effect on each letter, but it wouldnt be optimal performance wise and positioning was awful. So i chose just having it as an image behind the Title. |
| <Image | ||
| src={stoner} | ||
| alt="Pössyttelijä" | ||
| priority={true} |
There was a problem hiding this comment.
This is causing a build error because TypeScript is running into a JSX type conflict with the priority prop here. Please remove priority from images. It will fix the build, and since these images are lower down the page, letting Next.js lazy-load them naturally is actually better for performance.

📄 Pull Request Overview
Closes #657
🔧 Changes Made
✅ Checklist Before Submission
console.log()or other debugging statements are left.📝 Additional Information
Provide any additional context or information that reviewers may need to know:
swing.webm