Skip to content

Casimir43/enhancement/657 update coming soon page#662

Open
Casimir43 wants to merge 13 commits into
devfrom
casimir43/enhancement/657-update-coming-soon-page
Open

Casimir43/enhancement/657 update coming soon page#662
Casimir43 wants to merge 13 commits into
devfrom
casimir43/enhancement/657-update-coming-soon-page

Conversation

@Casimir43

@Casimir43 Casimir43 commented Jun 24, 2026

Copy link
Copy Markdown

📄 Pull Request Overview

Closes #657

🔧 Changes Made

  • Replaced the old hero character lineup with new characters
  • Added an SVG curved title with a fog background image
  • Added a swinging "coming soon" sign with animated text overlay
  • Added Finnish/English language-specific letter spacing
  • Created new folder for comingpage character

Checklist Before Submission

  • Functionality: I have tested my code, and it works as expected.
  • JSDoc: I have added or updated JSDoc comments for all relevant code.
  • Debugging: No console.log() or other debugging statements are left.
  • Clean Code: Removed commented-out or unnecessary code.
  • Tests: Added new tests or updated existing ones for the changes made.
  • Documentation: Documentation has been updated (if applicable).

📝 Additional Information

Provide any additional context or information that reviewers may need to know:

  • Decided to just use an image for the title fog instead of glass component.
  • different letter spacing due to using image instead of the glass component
image
swing.webm

@Casimir43 Casimir43 linked an issue Jun 24, 2026 that may be closed by this pull request
@Casimir43
Casimir43 changed the base branch from main to dev June 24, 2026 13:00

@Skoivumaki Skoivumaki left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing on tests. Fix or remove tests causing issues.

@Casimir43

Copy link
Copy Markdown
Author

Build is failing on tests. Fix or remove tests causing issues.

Removed the invalid assertion. Tests passes now.

@Casimir43
Casimir43 requested a review from Skoivumaki June 25, 2026 12:07

@Skoivumaki Skoivumaki left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The animation looks great 👍
There´s still some odd changes done, that require explanation or discarding:

  • You didn't use the Glass component that was requested, but I think your implementation might have been better/easier.
  • You removed Glass from HeaderDesktop/HeaderMobile, which breaks the component on pages its referred on. (it seems you were planning to use this component and decided not to, but forgot to remove the edits.)
  • Sometimes you implement fonts incorrectly, not serious but bad for structure. (https://github.com/Alt-Org/Altzone-WebPages/wiki/9.-Css-rules#fonts)
  • See comments

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this change done?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad reverted.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does editing navbar have to do with issue?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accident from my end. Editing Navbar is my other issue im working on. Forgot to switch branches more likely. Or just having both issues open and made the edits accidentally on another window that was suppose to be for the other issue.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll revert these

@Casimir43

Copy link
Copy Markdown
Author

The animation looks great 👍 There´s still some odd changes done, that require explanation or discarding:

  • You didn't use the Glass component that was requested, but I think your implementation might have been better/easier.
  • You removed Glass from HeaderDesktop/HeaderMobile, which breaks the component on pages its referred on. (it seems you were planning to use this component and decided not to, but forgot to remove the edits.)
  • Sometimes you implement fonts incorrectly, not serious but bad for structure. (https://github.com/Alt-Org/Altzone-WebPages/wiki/9.-Css-rules#fonts)
  • See comments

The pre-existing glass component does not like following curves(it would just be behind the title not follow along the curve). One way was to make the title so that each letter are seperate and apply the glass effect on each letter, but it wouldnt be optimal performance wise and positioning was awful. So i chose just having it as an image behind the Title.

@Casimir43
Casimir43 requested a review from Skoivumaki July 7, 2026 15:35

@Skoivumaki Skoivumaki left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes done👍

@Rutjake Rutjake left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is currently failing due to a TypeScript error:

Image

I've left a specific comment on the code.
Please verify and make sure the project builds successfully locally after making the fix.

<Image
src={stoner}
alt="Pössyttelijä"
priority={true}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing a build error because TypeScript is running into a JSX type conflict with the priority prop here. Please remove priority from images. It will fix the build, and since these images are lower down the page, letting Next.js lazy-load them naturally is actually better for performance.

@Casimir43
Casimir43 requested a review from Rutjake July 20, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Coming Soon Page Match New Figma Designs

3 participants