Skip to content

fix: links in header and footer working like popups #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rushiiMachine merged 2 commits into from
Aug 31, 2026
Merged

fix: links in header and footer working like popups #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0459d1b
Refactor M3EButtonWithIcon for conditional rendering
twixxty Jul 29, 2026
7950954
Refactor footer links for improved accessibility
twixxty Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions src/components/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,21 @@ export function Footer() {
</p>
</div>
<m3e-button-group aria-label="Footer links" size="medium" variant="connected">
<m3e-button as="a" href="https://github.com/Aliucord/documentation" target="_blank" variant="tonal" style={{ fontFamily: 'Roboto, ui-sans-serif, system-ui', fontSize: '1rem', minWidth: 0 }}>
Documentation
</m3e-button>
<m3e-button as="a" href="https://github.com/Aliucord/Aliucord" target="_blank" variant="tonal" style={{ fontFamily: 'Roboto, ui-sans-serif, system-ui', fontSize: '1rem', minWidth: 0, marginLeft: '0.5rem' }}>
GitHub
</m3e-button>
<m3e-button as="a" href="https://discord.gg/EsNDvBaHVU" target="_blank" variant="tonal" style={{ fontFamily: 'Roboto, ui-sans-serif, system-ui', fontSize: '1rem', minWidth: 0, marginLeft: '0.5rem' }}>
Support Server
</m3e-button>
<a href="https://github.com/Aliucord/documentation" target="_blank" rel="noreferrer" style={{ display: 'contents' }}>
<m3e-button variant="tonal" style={{ fontFamily: 'Roboto, ui-sans-serif, system-ui', fontSize: '1rem', minWidth: 0 }}>
Documentation
</m3e-button>
</a>
<a href="https://github.com/Aliucord/Aliucord" target="_blank" rel="noreferrer" style={{ display: 'contents' }}>
<m3e-button variant="tonal" style={{ fontFamily: 'Roboto, ui-sans-serif, system-ui', fontSize: '1rem', minWidth: 0, marginLeft: '0.5rem' }}>
GitHub
</m3e-button>
</a>
<a href="https://discord.gg/EsNDvBaHVU" target="_blank" rel="noreferrer" style={{ display: 'contents' }}>
<m3e-button variant="tonal" style={{ fontFamily: 'Roboto, ui-sans-serif, system-ui', fontSize: '1rem', minWidth: 0, marginLeft: '0.5rem' }}>
Support Server
</m3e-button>
</a>
</m3e-button-group>
</div>
</div>
Expand All @@ -44,4 +50,4 @@ export function Footer() {
</div>
</footer>
);
}
}
15 changes: 11 additions & 4 deletions src/components/Hero.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,10 @@ import MaterialIcon from "./MaterialIcon";
function M3EButtonWithIcon({ icon, label, href, variant = "filled", size = "medium", target, rel, trailingIcon, style, ...rest }) {


return (
const button = (
<m3e-button
variant={variant}
size={size}
href={href}
target={target}
rel={rel}
style={style}
{...rest}
>
Expand All @@ -24,6 +21,16 @@ function M3EButtonWithIcon({ icon, label, href, variant = "filled", size = "medi
{trailingIcon && <m3e-icon slot="trailing-icon">{trailingIcon}</m3e-icon>}
</m3e-button>
);

if (href) {
return (
<a href={href} target={target} rel={rel} style={{ display: "contents" }}>
{button}
</a>
);
}

return button;
}

export function Hero() {
Expand Down