[PWGJE] Created new task: Produce tables for diffusion wake analysis#16570
[PWGJE] Created new task: Produce tables for diffusion wake analysis#16570nicola-wilson wants to merge 12 commits into
Conversation
nicola-wilson
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern,
nzardosh and
raymondEhlers
as code owners
|
O2 linter results: ❌ 10 errors, |
nzardosh
left a comment
nzardosh
left a comment
There was a problem hiding this comment.
thanks for the PR :) Please find some comments below
| { | ||
|
|
||
| // Track properties | ||
| DECLARE_SOA_COLUMN(ColID, colid, int32_t); // Collision ID |
There was a problem hiding this comment.
this should be an index coloumn
| } | ||
|
|
||
| using bcs = aod::BCs; | ||
| void process(soa::Join<aod::Collisions, aod::EvSels,aod::CentFT0Cs, aod::TPCMults, aod::QvectorFT0Cs>::iterator const& col, |
There was a problem hiding this comment.
It would be great if you could use the JE tables like JCollisions to remove as much dependency as possible on non derived formats
| testtrack::ColID, | ||
| testtrack::Charge, | ||
| testtrack::P, | ||
| testtrack::DEdx, |
There was a problem hiding this comment.
what is the purpose of this fir diffusion wake studies?
Please consider the following formatting changes to AliceO2Group#16570
| #include <Framework/ASoA.h> | ||
| #include <Framework/AnalysisDataModel.h> | ||
| #include <Framework/AnalysisHelpers.h> | ||
| #include <Framework/AnalysisTask.h> | ||
| #include <Framework/HistogramRegistry.h> | ||
| #include <Framework/HistogramSpec.h> | ||
| #include <Framework/InitContext.h> | ||
| #include <Framework/OutputObjHeader.h> | ||
| #include <Framework/runDataProcessing.h> | ||
| // For centrality: | ||
| #include "Common/DataModel/Centrality.h" | ||
| #include "Common/DataModel/EventSelection.h" | ||
| // For TPC Mult | ||
| #include "Common/DataModel/Multiplicity.h" | ||
| // For DCA and TrackSelection | ||
| #include "Common/DataModel/TrackSelectionTables.h" | ||
| // For EP | ||
| #include "Common/Core/EventPlaneHelper.h" | ||
| #include "Common/DataModel/Qvectors.h" | ||
| // For occupancy bit | ||
| #include "Common/CCDB/EventSelectionParams.h" |
There was a problem hiding this comment.
Remove all comments (or move them to the ends of lines). They block the sorting and grouping.
There was a problem hiding this comment.
Also make sure you include exactly what you use.
| o2physics_add_dpl_workflow(jet-deriveddata-producer | ||
| SOURCES derivedDataProducer.cxx | ||
| SOURCES jetDeriveddataProducer.cxx |
There was a problem hiding this comment.
These files are not modified in this PR.
vkucera
left a comment
vkucera
left a comment
There was a problem hiding this comment.
Fix the errors and warnings introduced by your PR.
5 participants
This task aims to write tables with collisions that contain at least one high pT track. These are then used by a Bachelor student at GSI who works on diffusion wakes and wants to apply his Run 2 analysis to Run 3 data (therefore, trees are needed). To reduce memory size, some variables are stored in a different format (for example px,py,pz)