Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A successful
fleet releasedispatch can leave a Cloud/provider sandbox running and incurring cost. Warn on stderr after adispatchedacknowledgement while retaining the existing single JSON document on stdout, including--delete-agentand--delete-agent --wait. This change does not request sandbox teardown.Fixes #1922.
Adds seven regression tests, one RelayFlow bugfix proof case, a patch changelog entry, and tracked Trail records.
Test Plan
npm run typecheckpasses with Git's Unix tools on PATH for the existing build scripts.git diff --checkpass. The same runner observesbugon exact basec1ffabbc4andfixedon exact headd4119014e; neither observation is selected from the proof arm.Validation limits: the complete fleet file has 114 passing tests and one Windows path failure in
--checkout keeps cross-repo --cwd inference on the actual checkout while using the explicit project workspace(/workspace-projectversusC:\workspace-project). Unchanged base reproduces the same failure with 107 passing tests. The broader Windows suite (npm test --ignore-scripts -- --reporter=json) did not pass: its report records 3,040 passed, 342 failed, and 38 pending tests, and a worker ran out of heap memory. This PR remains draft pending maintainer validation on Linux. Fork PRs also require a maintainer to reproduce the branch and proof case in the upstream repository before the credential-bearing Cloud proof can run, per the case README.RelayFlow Proof
bugfix1922-fleet-release-sandbox-warningScreenshots
Not applicable; CLI warning only.
Need help on this PR? Tag
@codesmith-botwith what you need.