Repository navigation
Add pull request verification workflow - #41
Draft
willwashburn wants to merge 2 commits into
Draft
willwashburn wants to merge 2 commits into
willwashburn wants to merge 2 commits into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Keep the branch's typecheck/lint scripts and oxlint devDependency; take main's script set otherwise (deploy scripts were removed on main, dev:teams and verify:* added).
Contributor
|
Preview deployed!
This is a Cloudflare Workers preview version of this PR's build. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull_requestworkflow that installs dependencies, typechecks, lints, tests, and buildstypecheckandlintscripts covering both workspacesRoot cause
The repository's only pull-request workflow uploads a Cloudflare preview. The other two workflows deploy after pushes. As a result, a PR check rollup could appear green without any typecheck, lint, test, or ordinary production build having run.
This workflow is deliberately independent of
.github/workflows/preview.yml; it does not change that workflow's triggers or deploy behavior. Its permissions are read-only and checkout does not persist credentials.Verification
actionlint .github/workflows/verify.ymlnpm cinpm run typechecknpm run lint— 204 filesnpm test— 94/94 testsnpm run build— 388 static pagesnpm audit --json— unchanged at 9 findings (1 low, 8 high), tracked separately in Audit and remediate 9 npm vulnerability findings #40Gate
Draft only. Do not merge until the two-review rule is satisfied at the exact current head and cmo/chief release the gate.
Summary by cubic
Adds a read-only pull request workflow that runs typecheck, lint, tests, and build, so PR checks cover code quality and production builds as well as preview deploys.
typecheckandlintscripts and pinsoxlintto1.76.0.Written for commit af49c31. Summary will update on new commits.