fix(release): align package metadata and workflow action pins#468
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the project version to 15.0.0 and introduces pydantic as a mandatory dependency in setup.py. The reviewer recommends consolidating all package metadata into pyproject.toml to follow modern Python packaging standards (PEP 621), which would resolve the current issue of duplicated metadata across configuration files.
Ensure release automation updates pyproject metadata to prevent duplicate-version PyPI publishes, and pin workflow actions to current immutable SHAs for consistency and security. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
thomasc-adyen
force-pushed
the
fix/release-publishing
branch
from
1c585b1 to
64097b3
Compare
|
gcatanese
approved these changes
Mar 31, 2026
Merged
erdemtuna
added a commit
to erdemtuna/adyen-python-api-library
that referenced
this pull request
Apr 7, 2026
Make pyproject.toml the single source of truth for all package metadata, eliminating the duplication between setup.py and pyproject.toml that caused the pydantic dependency bug (PR Adyen#468). Changes: - Simplify setup.py to minimal 2-line shim (FR-002) - Bump build-system.requires to setuptools>=61.0.0 (FR-005) - Add [project.urls] with Homepage/Repository/Issues (FR-004) - Add [tool.setuptools.packages.find] with include=["Adyen*"] (FR-003) - Update Makefile install to use pyproject.toml extras (FR-006) - Remove setup.py from release.yml version-files (FR-007) - Update lint.yml cache key to hash pyproject.toml (FR-008) Resolves Adyen#471 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure release automation updates pyproject metadata to prevent duplicate-version PyPI publishes, and pin workflow actions to current immutable SHAs for consistency and security.