Repository navigation
fix(access): single retry render for per-chain eligibility failures - #303
Merged
Merged
Conversation
Pull request
Pull request
Pull Request
Remove duplicated per-chain list rendering in PerChainEligibilityList so each chain row renders once with its retry affordance. Harden retryChain so an unexpected resolver rejection can never leave a chain stuck in the resolving state. Add hook test covering the merge behavior when a retried chain fails again while successful siblings remain untouched, and assert the UI only surfaces the retry button for timed-out/error entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #167
-Remove duplicated per-chain list rendering in PerChainEligibilityList so each chain row renders once with its retry affordance.
-Harden retryChain so an unexpected resolver rejection can never leave a chain stuck in the resolving state.
-Add hook test covering the merge behavior when a retried chain fails again while successful siblings remain untouched, and assert the UI only surfaces the retry button for timed-out/error entries.