Skip to content

Fix/role eligibility wrong account - #301

Merged
Lakes41 merged 4 commits into
Adamantine-guild:mainfrom
abojeEdwin:fix/role-eligibility-wrong-account
Sep 14, 2026
Merged

Lakes41 merged 4 commits into
Adamantine-guild:mainfrom
abojeEdwin:fix/role-eligibility-wrong-account

Conversation

@abojeEdwin

Copy link
Copy Markdown
Contributor

Closes #171

Description

Linked Issue

Closes #

Type of Change

  • 🐛 Bug fix (screen or component)
  • ✨ New feature / screen
  • 🎨 UI/UX improvement
  • 📝 Documentation update
  • 🔧 Chore / refactor / dependency update
  • 🧪 Tests only

Changes Made

Screenshots / Recordings

iOS Android

Test Evidence

pnpm test:run output:

Checklist

  • I have read CONTRIBUTING.md
  • This PR is linked to an open issue
  • pnpm typecheck passes
  • pnpm lint passes
  • pnpm test:run passes — all tests green
  • UI changes include a screenshot or screen recording
  • New screens handle loading, empty, and error states
  • NativeWind (Tailwind) classes used — no StyleSheet.create for new UI without justification
  • No native modules added that break Expo Go compatibility (without prior discussion)
  • No secrets, keys, or wallet credentials included
  • .env.example updated if new environment variables were added
  • Accessibility: interactive elements are keyboard-navigable and have accessibility labels

Additional Notes

abojeEdwin and others added 4 commits September 14, 2026 01:59
…contract

Add regression coverage for the on-chain role-eligibility resolver so the
ABI-encoded account argument to hasRole(bytes32,address) is the connected
wallet address — deliberately different from the role contract address —
and the resolved result reflects the caller's own role status.
@Lakes41
Lakes41 merged commit f42b909 into Adamantine-guild:main Sep 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix the on-chain role-eligibility resolver checking the wrong account

2 participants