Mechanize two more Blast Radius facts, require branch-only coding work - #80
Merged
Conversation
Extends the six ADR-003 numerical-component entities' must_appear_in to also check docs/architecture/icds.md and their own handbook page, fixing three headings icds.md had spelled differently from everywhere else (Time Integrator/Linear Solver/Boundary Condition -> the canonical plural forms) along with every real cross-reference to them. Adds a new gated rule, ka-name-matches-manifest, to check_manifest.py: where a manifest row and a knowledge-architecture.md entry both cite the same KA-NNN, they must name the same file. Deliberately scoped to agreement rather than completeness in either direction, for the same reason this validator's own dropped fourth rule was dropped. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Standing rule, maintainer's instruction: create a branch before the first edit rather than after, so docs/practices.md's branch-naming and one-branch-per-task conventions apply every time instead of only when someone remembers to branch first. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
must_appear_into also checkdocs/architecture/icds.mdand their own handbook page, fixing three headingsicds.mdhad spelled differently from everywhere else (Time Integrator/Linear Solver/Boundary Condition -> the canonical plural forms) along with every real cross-reference to them.ka-name-matches-manifest, tocheck_manifest.py: where a manifest row and aknowledge-architecture.mdentry both cite the sameKA-NNN, they must name the same file. Deliberately scoped to agreement rather than completeness in either direction, for the same reason this validator's own dropped fourth rule was dropped.CLAUDE.md: all coding work happens on a branch, never directly onmain.Test plan
make check-graph— cleanmake check-manifest— cleanmake check-docs— cleanmake lint/make typecheck— cleanmake test— newcheck_manifest.pytests pass, full suite greenmake ci— full pipeline greenicds.mdheading locally and confirmedmake check-graphfails withentity-name-appears-in-sources, then reverted back — proves the new gate has teeth, not just a clean pass by luck🤖 Generated with Claude Code