Skip to content

feat(api): Reset the set venv - #47

Open
aemonge wants to merge 15 commits into
AckslD:mainfrom
aemonge:main
Open

feat(api): Reset the set venv#47
aemonge wants to merge 15 commits into
AckslD:mainfrom
aemonge:main

Conversation

@aemonge

@aemonge aemonge commented Dec 17, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@AckslD

AckslD commented Dec 22, 2024

Copy link
Copy Markdown
Owner

Hi @aemonge! Thanks for the PR, I'm planning to look into this in more detail soon. Would you in the meantime remove all the formatting changes which distracts from the actual changes. I should probably add a stylua.toml to this repo as I preper 2 spaces as indentation.

@aemonge

aemonge commented Jan 8, 2025

Copy link
Copy Markdown
Contributor Author

Is this better?

@AckslD

AckslD commented Jan 11, 2025

Copy link
Copy Markdown
Owner

Yes, thanks! Would you also mind adding quote_style = "AutoPreferSingle" to the stylua.toml? Or let me know if you prefer me to do it.

@aemonge

aemonge commented Jan 14, 2025

Copy link
Copy Markdown
Contributor Author

:) Done

Comment thread lua/swenv/api.lua Outdated
Comment thread lua/swenv/api.lua Outdated
@AckslD

AckslD commented Feb 5, 2025

Copy link
Copy Markdown
Owner

Btw, not sure why CI is failing, need to look into that, seems unrelated to this PR

Comment thread lua/swenv/api.lua Outdated
@aemonge

aemonge commented Feb 5, 2025

Copy link
Copy Markdown
Contributor Author

Please let me know if it's related to the PR, and I'll work on it :)

It feels good to participate in the repo.

@AckslD

AckslD commented Feb 9, 2025

Copy link
Copy Markdown
Owner

If you rebase on main now the CI should work again. Please also fix the remaining Path join changes, see above.

@aemonge

aemonge commented Feb 11, 2025

Copy link
Copy Markdown
Contributor Author

Hey @AckslD there were too many conflicts for a rebase, I hope a merge is ok with you.

Comment thread lua/swenv/api.lua Outdated
@aemonge

aemonge commented Mar 12, 2025

Copy link
Copy Markdown
Contributor Author

I've also added support for UV with .venv dirs, let me know it I should split the MR

Comment thread lua/swenv/api.lua
@aemonge

aemonge commented Mar 17, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for noticing this @neolooong

@aemonge

aemonge commented Apr 7, 2025

Copy link
Copy Markdown
Contributor Author

@AckslD Code was broken, now it should work 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants