[Backport version-16-hotfix] feat: read a manifest grid without opening every row - #483
Merged
Merged
Conversation
Reading a manifest meant opening a row to see whether a container was a box and whether it came full or loose. Both now sit in the grid beside the container number, and the grid holds 50 rows with search above 20. (cherry picked from commit 834f316)
… grid The same two columns as the manifest container grid, in the same order, so the two read alike. Container size gives up its column to them. (cherry picked from commit 6edb778)
The guard compares each row against the first, so it names two bills while a manifest can carry more. A real file has been seen with one container under three, and the message read as though two were the whole of it. (cherry picked from commit b7694d5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #479 to
version-16-hotfix.Manifest and house bill grids
Reading a manifest meant opening a row to see whether a container was a box and whether it arrived full or loose. Type of Container and Freight Indicator now sit in both grids, beside the container number:
Containers Detail)HBL Container)Both grids hold 50 rows per page and show the search box above 20 rows. On the house bill grid, Container Size gives up its column so the two read alike.
Duplicate bill of lading message
validate_one_bill_of_ladingcompares each container row against the first bill it was seen under, so it can only ever name two bills — while a manifest can carry more. A real file has now been seen with one container under three bills of lading, and the message read as though two were the whole of it.Before:
After:
Wording only. The guard itself is unchanged: a container under more than one bill is still rejected, because its costs cannot be attributed to a single bill.
Testing
No behaviour change to test beyond the existing suite — 295 passing.
pre-commit run --all-filesandruff checkgreen.The grid changes take effect after
bench migrate.