board: aspeed: 2700: enable power sequencing only on AC power cycle - #60
Open
rajaganeshr wants to merge 1 commit into
Open
board: aspeed: 2700: enable power sequencing only on AC power cycle#60rajaganeshr wants to merge 1 commit into
rajaganeshr wants to merge 1 commit into
Conversation
HPM power sequencing should be performed only during a cold boot (AC power cycle). BMC reboot events must not trigger power sequencing again, as doing so can disrupt the current host power state. Tested: Verified on Arthur Signed-off-by: Rajaganesh Rathinasabapathi <Rajaganesh.Rathinasabapathi@amd.com>
rajaganeshr
requested review from
aasboddu,
ankitaprasad2206,
mahkurap and
modolaty
August 19, 2026 07:06
mahkurap
requested changes
Aug 19, 2026
mahkurap
approved these changes
Aug 19, 2026
amd-knieman
reviewed
Aug 19, 2026
| bool rev_b = is_scm_rev_b(); | ||
| bool ac_cycle_boot = (por_rst_env && !strcmp(por_rst_env, "true")); | ||
|
|
||
| if (!ac_cycle_boot) { |
There was a problem hiding this comment.
Do we need to add a check to see if the HPM power sequence is actually up? Would there ever be a case in which power sequencing fails, and BMC reboots? (Pretty unlikely I would think?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HPM power sequencing should be performed only during a cold boot (AC power cycle).
BMC reboot events must not trigger power sequencing again, as doing so can disrupt the current host power state.