Add DRAM CECC and fatal harvest delay config options - #189
Open
aasaitha0219 wants to merge 1 commit into
Open
Conversation
ojayanth
suggested changes
Aug 6, 2026
ojayanth
left a comment
ojayanth
left a comment
There was a problem hiding this comment.
Please address the code alignment and formatting issues first. We can continue the functional review afterward.
aasaitha0219
force-pushed
the
additional_ras_config
branch
3 times, most recently
from
August 18, 2026 21:35
96883a0 to
eeb82c8
Compare
Add configurable DRAM CECC OOB error counter mode and fatal harvest delay override to give BMC control over error counting behavior and syncflood reset timing. Reason: - DRAM CECC error counter mode was hardcoded to 1 (no-leak mode), preventing use of leaky bucket mode preferred for production. - Fatal harvest delay was not configurable, meaning BMC could not ensure sufficient time to collect MCA data before CPU reset. Changes: - Add DramCeccOobEcMode config (0=disabled, 1=no-leak, 2=leaky bucket) with default value 2 and MaxBoundLimit 2. - Add DramCeccLeakRate config (0x00-0x1F) with default 20 and MaxBoundLimit 31. Only used when DramCeccOobEcMode=2. - Add FatalHarvestDelayEn config (bool) with default true. - Add FatalHarvestDelayMins config (5-120 mins) with default 5. - Update getOobRegisters() and getRasOobConfig() to parse dram_cecc_leak_rate. - Update setMcaOobConfig() to use config values instead of hardcoded. - Update setMcaErrThreshold() for DRAM CECC threshold config values. - Add setFatalHarvestDelay() calling override_delay_reset_on_sync_flood. - Call setFatalHarvestDelay() in platformInitialize, watchdog handler, and runTimeErrorPolling wherever OOB configs are set/reapplied. Impact: - Users can configure DRAM CECC error counting via ras_config.json. - Leaky bucket mode (default) provides better production tracking. - Fatal harvest delay ensures time to collect MCA data after syncflood. - Config is reapplied on warm reboot and BIOS post complete events. Signed-off-by: Avenash Asai Thambi <aasaitha@amd.com>
aasaitha0219
force-pushed
the
additional_ras_config
branch
from
August 18, 2026 21:38
eeb82c8 to
1d5e6d0
Compare
Collaborator
Author
|
@ojayanth please review it again. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add configurable DRAM CECC OOB error counter mode and fatal harvest delay override to ras_config.json.
Changes
DRAM CECC OOB Config
DramCeccOobEcModeconfig (0=disabled, 1=no-leak, 2=leaky bucket)DramCeccLeakRateconfig (0x00-0x1F leak rate)dram_cecc_oob_ec_mode = 1with configurable valuesFatal Harvest Delay Override
setFatalHarvestDelay()to calloverride_delay_reset_on_sync_floodFatalHarvestDelayEn/FatalHarvestDelayMinsconfig keysTesting
Fatal harvest delay test log.txt
References
#154
#179