fix: honor G4OpticalParameters process activation flags in DDG4#1636
Open
wdconinc wants to merge 1 commit into
Open
fix: honor G4OpticalParameters process activation flags in DDG4#1636wdconinc wants to merge 1 commit into
wdconinc wants to merge 1 commit into
Conversation
…icalPhotonPhysics The Geant4OpticalPhotonPhysics DDG4 plugin previously unconditionally constructed and registered all four optical processes (G4OpAbsorption, G4OpRayleigh, G4OpMieHG, G4OpBoundaryProcess) regardless of the G4OpticalParameters activation flags set by the user. This patch makes the plugin (for Geant4 >= 10.7) check each process against G4OpticalParameters::GetProcessActivation() before adding it to the G4ProcessManager. Processes that are deactivated are safely deleted instead. G4OpBoundaryProcess is always registered since it controls all surface interactions. Additionally, OpWLS and OpWLS2 are now registered when activated, completing the set of optical processes that can be controlled via /process/optical/processActivation <ProcessName> true/false The log message now dynamically lists the actually-registered processes instead of a hardcoded string. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
https://github.com/AIDASoft/DD4hep/actions/runs/26594571685/job/78361956607?pr=1636 can't find ROOT for some reason... |
Test Results 18 files 18 suites 7h 29m 43s ⏱️ For more details on these failures, see this check. Results for commit d16f338. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Geant4OpticalPhotonPhysics DDG4 plugin previously unconditionally constructed and registered all four optical processes (G4OpAbsorption, G4OpRayleigh, G4OpMieHG, G4OpBoundaryProcess) regardless of the G4OpticalParameters activation flags set by the user.
This patch makes the plugin (for Geant4 >= 10.7) check each process against G4OpticalParameters::GetProcessActivation() before adding it to the G4ProcessManager. Processes that are deactivated are safely deleted instead. G4OpBoundaryProcess is always registered since it controls all surface interactions.
Additionally, OpWLS and OpWLS2 are now registered when activated, completing the set of optical processes that can be controlled via
The log message now dynamically lists the actually-registered processes instead of a hardcoded string.
BEGINRELEASENOTES
ENDRELEASENOTES