Repository navigation
Merge latest Library.Template - #239
Merged
Merged
Conversation
… (575) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Avoid re-installing .NET SDK or runtimes
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Re-running a failed docs deployment failed because the prior attempt's github-pages artifact remained, making deploy-pages find two artifacts. Use a per-attempt artifact name, and allow workflow_dispatch. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ci: Pin Ubuntu runners to 26.04
Build NativeAOT-safe libraries
… (582) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
… (583) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Specifically, this merges [580ec8a from that repo](AArnott/Library.Template@580ec8a). NativeAOT opted out (same xunit data-source / xunit.v3.core IL issues as Combinatorial). Kept README, version 4.1-beta, windows docs runner, mac restore config, cloud trait filters; preferred template test-cloud IncludeNativeAOT plumbing but left PublishNativeAOTTests=false.
AArnott
marked this pull request as ready for review
October 5, 2026 21:34
Owner
|
Usher summary (local MergeFrom-Template; NativeAOT opted out)
|
AArnott
enabled auto-merge
October 5, 2026 21:34
test/dirs.proj was pulling Xunit.StaFact.Tests.Mac into tools/dirs.proj on Linux/Windows. Keep Mac coverage on the dedicated macOS workflow step.
AArnott
disabled auto-merge
October 5, 2026 21:53
Merge conflict resolution dropped backslashes in the v\\d+\\.\\d+ regex, producing invalid JSON and breaking nbgv inherit/walk.
Prefer the template only where the repo’s prior content was equivalent. Restore xunit (or classic VSTest) AGENTS.md guidance where tests did not migrate to TUnit, drop unused TUnit CPM package versions, and reinstate cloud-test filters and bespoke test runner behavior that the template overwrite removed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
=======================================
Coverage 82.48% 82.48%
=======================================
Files 48 48
Lines 1079 1079
Branches 106 106
=======================================
Hits 890 890
Misses 155 155
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Linux/macOS CI was failing with exit 150 when MTP tried to launch the
net8.0-windows test host ("You must install or update .NET").
…telliteResourceLanguages (#585) test/AOT.props is imported from test/Directory.Build.targets, which evaluates after the project body. Unconditional assignments therefore clobbered a project's explicit opt-out (e.g. InvariantGlobalization=false for culture-dependent tests).
Specifically, this merges [05c2761 from that repo](AArnott/Library.Template@05c2761). Conflict in test/AOT.props (modified upstream, deleted here) resolved by keeping it deleted: this xunit extension library opted out of the template's NativeAOT test infrastructure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original prompt