Optimize LightList copies#2
Draft
8Keep wants to merge 1 commit into
Draft
Conversation
8Keep
force-pushed
the
jmh-benchmark-harness
branch
from
May 19, 2026 22:53
cc0750d to
2876086
Compare
8Keep
force-pushed
the
lightlist-hotpath-copies
branch
from
May 19, 2026 23:09
5906442 to
bd6da59
Compare
8Keep
force-pushed
the
jmh-benchmark-harness
branch
from
May 27, 2026 02:42
2876086 to
dc27f27
Compare
8Keep
force-pushed
the
lightlist-hotpath-copies
branch
from
May 27, 2026 02:45
bd6da59 to
6b2ec09
Compare
8Keep
force-pushed
the
jmh-benchmark-harness
branch
from
May 27, 2026 18:23
dc27f27 to
b0fce5b
Compare
8Keep
force-pushed
the
lightlist-hotpath-copies
branch
2 times, most recently
from
May 27, 2026 18:43
4400dac to
e2dfcf2
Compare
8Keep
force-pushed
the
jmh-benchmark-harness
branch
from
May 28, 2026 20:05
b0fce5b to
5c81b07
Compare
8Keep
force-pushed
the
lightlist-hotpath-copies
branch
from
May 28, 2026 20:05
e2dfcf2 to
5fe394e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs my jmh harness PR in jMonkeyEngine#2778
Summary
LightListbacking capacityLightListregression tests for removal ordering, update ordering/filtering, and sorting after retained capacityBenchmark Results
JMH results from the
jme3-corebenchmark harness, lower is better:Before -> After
removeFromFront, 256 lights:0.317 us/op->0.036 us/opremoveFromMiddle, 256 lights:0.172 us/op->0.031 us/opupdateFromLocalAndParent, 256 lights:0.738 us/op->0.195 us/opsortTransformChanged, 256 lights, retained x1024:94.191 us/op->25.909 us/opTesting
./gradlew :jme3-core:test --tests com.jme3.light.LightListTest :jme3-core:benchmarkClasses