refactor(remember-me): remove recurrfreq and donation amount handling - #430
Merged
Conversation
Reapplies PR #429 over the updated main (which had merge conflicts). Removes: - DonationFrequency import/usage and _frequency instance - fieldDonationRecurrFreqRadioName option and its writeFields() radio-group handling - Custom Other amount save/restore fixes in readFields()/writeFields() - reapplyDonationAmtAfterSwap() and getCurrentSelectedAmount() Retains AES-GCM encryptData, hide, fieldClearLabel, and the main's i18n (rememberMeLabel / ENGrid.t) additions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR reverts the
RememberMecomponent's recurring-frequency handling and the custom donation-amount logic that were introduced in #412, while keeping the other features from that PR.Removed
DonationFrequencydependency — theimportfrom./eventsand the_frequencyinstance are gone.RememberMeno longer subscribes toonFrequencyChange.fieldDonationRecurrFreqRadioNameoption — the field declaration, constructor parameter, default assignment (transaction.recurrfreq), and the dedicatedrecurrfreqradio-group branch inwriteFields()were removed. The matching docs entry inrememberme.mdwas dropped as well.readFields()no longer special-cases the "Other" radio to persist the numeric value from the.othertext input, andwriteFields()no longer clicks the "Other" radio before filling the text input. ThedonationAmtblock inwriteFields()is back to its pre-feat: add new functionallity for remember me #412 behavior.reapplyDonationAmtAfterSwap()andgetCurrentSelectedAmount()— both methods and their three call sites in the constructor branches were removed.RememberMeno longer re-applies the donation amount afterSwapAmountsreplaces the DOM.