Skip to content

fix: include render_offset_top in virtual padding reservation #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Haegin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: include render_offset_top in virtual padding reservation #356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lua/image/image.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,9 @@ function Image:render(geometry)
local filler = {}
local extmark_opts = { id = self.internal_id, strict = false }
if self.with_virtual_padding then
-- only reserve real height for the extmark, padding is applied during rendering
local total_lines = height
-- reserve image height plus render_offset_top, since the offset
-- shifts the rendered image down without removing any of its rows
local total_lines = total_height
for _ = 0, total_lines - 1 do
filler[#filler + 1] = { { " ", "" } }
end
Expand Down