Skip to content

feat: add deploy script for MorphoAllocator only #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxencerb merged 2 commits into from
Jul 9, 2026
Merged

feat: add deploy script for MorphoAllocator only #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7ba92f
feat: add deploy script for MorphoAllocator only
maxencerb Jul 9, 2026
9ce82a3
fix: use Solady canonical ERC1967Factory address
maxencerb Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion script/DeployAllocators.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ contract DeployAllocators is Script {
/*.•°:°.´+˚.*°.˚:*.´•*.+°.•°:´*.´•*.•°.•°:°.´:•˚°.*°.˚:*.´+°.•*/

/// @notice Solady ERC1967Factory used to deploy the upgradeable proxies.
IERC1967Factory internal constant FACTORY = IERC1967Factory(0x54F862fa0612A8709F6Dec4A7B39AF015CD4E82E);
IERC1967Factory internal constant FACTORY = IERC1967Factory(0x0000000000006396FF2a80c067f99B3d2Ab4Df24);

/// @notice Grunt Facility proxy both allocators coordinate (`facility_`).
address internal constant FACILITY = 0x4e013ca8fF612a58F53C822904cDD0eC538a4A4F;
Expand Down
82 changes: 82 additions & 0 deletions script/DeployMorphoAllocator.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
// SPDX-License-Identifier: BUSL-1.1
pragma solidity ^0.8.22;

import {Script} from "forge-std/Script.sol";
import {console2} from "forge-std/console2.sol";

import {MorphoAllocator} from "../src/MorphoAllocator.sol";

import {IFacility} from "@grunt/interfaces/facility/IFacility.sol";
import {IVaultV2} from "@vault-v2/interfaces/IVaultV2.sol";

/// @notice Minimal view of the Solady `ERC1967Factory` (deployed on mainnet). Inlined rather than
/// imported so the script does not pull in or compile the full factory implementation.
/// @dev `deployAndCall` deploys an ERC1967 proxy pointing at `implementation`, records `admin` as
/// the upgrade admin (the only address allowed to later call `upgrade`/`upgradeAndCall` on the
/// proxy via the factory), and delegatecalls `data` on the new proxy — atomically initializing
/// it in the same transaction.
interface IERC1967Factory {
function deployAndCall(address implementation, address admin, bytes calldata data)
external
payable
returns (address proxy);
}

/// @title DeployMorphoAllocator
/// @author 3F Protocol
/// @notice Deploys the `MorphoAllocator` Smart Facilitator behind an upgradeable ERC1967 proxy via
/// the Solady `ERC1967Factory`, initializing it in the same call. The implementation locks
/// direct initialization (`_disableInitializers`), so a usable instance only exists behind a
/// proxy.
/// @dev Deploy + initialize only. Two grants remain for the respective owners after this script and
/// are NOT performed here: the Facility owner must grant `FACILITATOR_ROLE` to the proxy, and
/// the Morpho Vault V2 curator must `setIsAllocator(morphoAllocator, true)`.
contract DeployMorphoAllocator is Script {
/*´:°•.°+.*•´.*:˚.°*.˚•´.°:°•.°•.*•´.*:˚.°*.˚•´.°:°•.°+.*•´.*:*/
/* ADDRESSES */
/*.•°:°.´+˚.*°.˚:*.´•*.+°.•°:´*.´•*.•°.•°:°.´:•˚°.*°.˚:*.´+°.•*/

/// @notice Solady ERC1967Factory used to deploy the upgradeable proxy.
IERC1967Factory internal constant FACTORY = IERC1967Factory(0x0000000000006396FF2a80c067f99B3d2Ab4Df24);

/// @notice Grunt Facility proxy the allocator coordinates (`facility_`).
address internal constant FACILITY = 0x4e013ca8fF612a58F53C822904cDD0eC538a4A4F;

/// @notice Morpho Vault V2 the MorphoAllocator allocates through (`morphoVault_`).
address internal constant MORPHO_VAULT = 0xBEEf3f3A04e28895f3D5163d910474901981183D;

/// @notice Owner granted on the allocator (3F_OWNER); controls EXECUTOR_ROLE.
address internal constant OWNER = 0xC82003FC812F8eFE93cdA63d9f8Ee8c0A3EF5d60;

/// @notice Address granted EXECUTOR_ROLE on the allocator (the only role allowed to call `run`).
address internal constant EXECUTOR = 0x95026A338084241E739250f4F9d2F5745dE81bDd;

/// @notice ERC1967 proxy upgrade admin (3F_ADMIN_PROTECTED); the only address allowed to upgrade
/// the proxy through the factory.
address internal constant PROXY_ADMIN = 0xA9F5262c1aa97C6E519D6f8837658C8f9979bA24;
Comment on lines +39 to +56

@coderabbitai coderabbitai Bot Jul 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Cross-check hardcoded addresses against DeployAllocators.s.sol if it exists.

# Find the sibling deployment script
fd -i "DeployAllocators" --type f

# If found, extract constant address definitions for comparison
fd -i "DeployAllocators.s.sol" --type f --exec rg -n '0x[0-9a-fA-F]{40}' {} \;

Repository: 3FLabs/facilitators

Length of output: 731

🌐 Web query:

"0x54F862fa0612A8709F6Dec4A7B39AF015CD4E82E Solady ERC1967Factory mainnet"

💡 Result:

The Ethereum address 0x54F862fa0612A8709F6Dec4A7B39AF015CD4E82E is not associated with the official Solady ERC1967Factory [1][2]. The canonical contract address for the Solady ERC1967Factory on Ethereum mainnet is 0x0000000000006396FF2a80c067f99B3d2Ab4Df24 [1][2]. This address is vanity-generated to include leading zero bytes [1]. If you are interacting with any contract address other than the verified canonical one, please exercise caution, as it is likely not part of the official Solady deployment [1][2][3].

Citations:

Use Solady’s canonical ERC1967Factory address

0x54F862fa0612A8709F6Dec4A7B39AF015CD4E82E is not the Solady mainnet factory. Replace it with 0x0000000000006396FF2a80c067f99B3d2Ab4Df24 in this script, and mirror the change in script/DeployAllocators.s.sol since both files share the same constant.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@script/DeployMorphoAllocator.s.sol` around lines 39 - 56, The ERC1967 factory
constant in DeployMorphoAllocator.s.sol is using the wrong address; update the
FACTORY value to Solady’s canonical mainnet ERC1967Factory address and apply the
same change in DeployAllocators.s.sol since both scripts share this deployment
constant. Keep the existing IERC1967Factory FACTORY symbol and adjust only the
address literal so the proxy deployment path uses the correct factory
everywhere.


/*´:°•.°+.*•´.*:˚.°*.˚•´.°:°•.°•.*•´.*:˚.°*.˚•´.°:°•.°+.*•´.*:*/
/* RUN */
/*.•°:°.´+˚.*°.˚:*.´•*.+°.•°:´*.´•*.•°.•°:°.´:•˚°.*°.˚:*.´+°.•*/

/// @notice Deploys and initializes the MorphoAllocator behind an ERC1967 proxy.
function run() external {
vm.startBroadcast();

MorphoAllocator morphoImpl = new MorphoAllocator();
address morphoProxy = FACTORY.deployAndCall(
address(morphoImpl),
PROXY_ADMIN,
abi.encodeCall(MorphoAllocator.initialize, (OWNER, EXECUTOR, IFacility(FACILITY), IVaultV2(MORPHO_VAULT)))
);

vm.stopBroadcast();

console2.log("MorphoAllocator impl :", address(morphoImpl));
console2.log("MorphoAllocator proxy:", morphoProxy);
console2.log("");
console2.log("Post-deploy (not done here):");
console2.log("- Facility owner: grant FACILITATOR_ROLE to the proxy");
console2.log("- Vault curator : setIsAllocator(morphoAllocator, true)");
}
}