Skip to content

fix: GetBandGainDB when a group center lands exactly on an octave band #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lmtanco wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: GetBandGainDB when a group center lands exactly on an octave band #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion 3dti_Toolkit/HAHLSimulation/GammatoneMultibandExpander.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,11 @@ namespace HAHLSimulation {
{
return (octaveBandAttenuations[gammatoneLowerBandGroupIndices[bandIndex]]);
}
else if (gammatoneLowerBandGroupFactors[bandIndex] > 0 && gammatoneHigherBandGroupFactors[bandIndex] > 0)
else if (gammatoneLowerBandGroupFactors[bandIndex] >= 0 && gammatoneHigherBandGroupFactors[bandIndex] >= 0)
{
// Note: this also correctly covers the case where the group's centre
// frequency lands exactly on an octave band (one factor is exactly 0.0),
// since a weight of 0 simply zeroes out that term of the interpolation.
return (octaveBandAttenuations[gammatoneLowerBandGroupIndices[bandIndex]]) * gammatoneLowerBandGroupFactors[bandIndex] +
(octaveBandAttenuations[gammatoneHigherBandGroupIndices[bandIndex]]) * gammatoneHigherBandGroupFactors[bandIndex];
}
Expand Down